Skip to content

fix: insert the global settings style at the start instead of appendi… #3528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfintal merged 2 commits into from
Jun 23, 2025
Merged

fix: insert the global settings style at the start instead of appendi… #3528

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03e56da
fix: insert the global settings style at the start instead of appendi…
Arukuen Jun 13, 2025
7b688dc
fix: move appending of global settings style to the head
Arukuen Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/plugins/global-settings/editor-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,15 @@ const GlobalSettingsLoader = () => {
useEffect( () => {
const editorBody = editorDom?.closest( 'body' )
if ( editorBody ) {
editorBody.appendChild( globalTypographyWrapper )
editorBody.appendChild( globalColorWrapper )
editorBody.appendChild( globalSpacingAndBorderWrapper )
editorBody.appendChild( globalButtonsAndIconsWrapper )
editorBody.appendChild( globalColorSchemesWrapper )
editorBody.appendChild( globalPresetControlsWrapper )
// No need to check for firstChild, since there will always be at least one
// e.g. the post title wrapper and the actual root container.
const firstChild = editorBody.firstChild
editorBody.insertBefore( globalTypographyWrapper, firstChild )
editorBody.insertBefore( globalColorWrapper, firstChild )
editorBody.insertBefore( globalSpacingAndBorderWrapper, firstChild )
editorBody.insertBefore( globalButtonsAndIconsWrapper, firstChild )
editorBody.insertBefore( globalColorSchemesWrapper, firstChild )
editorBody.insertBefore( globalPresetControlsWrapper, firstChild )
}
}, [ deviceType, editorDom ] )

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/theme-block-size/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const ThemeBlockSize = () => {
useEffect( () => {
const editorBody = editorDom?.closest( 'body' )
if ( editorBody ) {
editorBody.appendChild( themeBlockSizeWrapper )
editorBody.insertBefore( themeBlockSizeWrapper, editorBody.firstChild )
}
}, [ deviceType, editorDom ] )

Expand Down
Loading