-
Notifications
You must be signed in to change notification settings - Fork 67
Fix: Global Settings not showing for non-admin users #3533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bfintal
merged 11 commits into
develop
from
fix/3531-global-settings-not-showing-for-non-admin-users
Jun 25, 2025
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3937748
allow other roles to read stackable options
kaeizen 9aaae60
allow non-admin users to read stackable options for Global Settings
kaeizen 39fac01
hide global settings for non-admin
kaeizen 5f735bf
Update src/plugins/global-settings/index.js
bfintal 3d11fae
update request url for fetching settings
kaeizen ddd703e
add debug logs
kaeizen 335b15e
update request url for test
kaeizen 48c6075
update urls
kaeizen 26fb24b
update path
kaeizen 64683bc
update request url
kaeizen b236860
update test url
kaeizen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| <?php | ||
| /** | ||
| * This allows non-admin users to read Stackable Options for Global Settings in the Editor | ||
| */ | ||
|
|
||
| // Exit if accessed directly. | ||
| if ( ! defined( 'ABSPATH' ) ) { | ||
| exit; | ||
| } | ||
|
|
||
| if ( ! class_exists( 'Stackable_Admin_Settings' ) ) { | ||
|
|
||
| class Stackable_Admin_Settings extends WP_REST_Settings_Controller { | ||
|
|
||
| /** | ||
| * Constructor. | ||
| * | ||
| */ | ||
| public function __construct() { | ||
| $this->namespace = 'stackable/v3'; | ||
| $this->rest_base = 'settings'; | ||
| add_action( 'rest_api_init', array( $this, 'register_routes' ) ); | ||
| } | ||
|
|
||
| public function register_routes() { | ||
| register_rest_route( | ||
| $this->namespace, | ||
| '/' . $this->rest_base, | ||
| array( | ||
| 'methods' => WP_REST_Server::READABLE, | ||
| 'callback' => array( $this, 'get_item' ), | ||
| 'args' => array(), | ||
| 'permission_callback' => array( $this, 'retrieve_item_permissions_check' ), | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| public function retrieve_item_permissions_check( $request ) { | ||
| return current_user_can( 'edit_posts' ); | ||
| } | ||
|
|
||
| /** | ||
| * Retrieves only the Stackable registered options | ||
| * | ||
| * @return array Array of registered options. | ||
| */ | ||
| protected function get_registered_options() { | ||
| $rest_options = parent::get_registered_options(); | ||
|
|
||
| $rest_options = array_filter( | ||
| $rest_options, | ||
| function( $key ) { | ||
| return strpos( $key, 'stackable' ) === 0; | ||
| }, | ||
| ARRAY_FILTER_USE_KEY | ||
| ); | ||
|
|
||
| return $rest_options; | ||
| } | ||
| } | ||
|
|
||
| new Stackable_Admin_Settings(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.