Skip to content

fix: exclude freemiums section to the global ul style for stackable #3685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfintal merged 1 commit into from
May 3, 2026
+4 −0
Merged

fix: exclude freemiums section to the global ul style for stackable #3685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/welcome/admin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,10 @@ body[class*="page_stk"] {
padding-left: 2em;
list-style-type: circle;
}
.fs-section ul {
list-style-type: none;
}
Comment on lines +442 to +444
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

# First, examine the SCSS file to confirm the parent ul rule and the new fix
cat -n src/welcome/admin.scss | sed -n '430,450p'

Repository: gambitph/Stackable

Length of output: 526

🏁 Script executed:

# Search for the broader context around lines 442-444 to see the parent rule
cat -n src/welcome/admin.scss | sed -n '438,450p'

Repository: gambitph/Stackable

Length of output: 349

🏁 Script executed:

# Search for Freemius-related templates and action button rendering
rg -n "fs-section|fs-actions|Start Debug|Sync" --type=php -A 3 -B 3

Repository: gambitph/Stackable

Length of output: 26715

🏁 Script executed:

# Search for other CSS rules targeting fs-section or related selectors in the SCSS file
rg -n "\.fs-section|\.fs-actions" src/welcome/admin.scss -A 3 -B 1

Repository: gambitph/Stackable

Length of output: 131

🏁 Script executed:

# Search for the full context of the action buttons list in the account template
cat -n freemius/templates/account.php | sed -n '275,375p'

Repository: gambitph/Stackable

Length of output: 9521

🏁 Script executed:

# Check if there are any inline styles or other CSS affecting the Freemius button layout
rg -n "fs-section|fs-actions" --type=php -B 2 -A 5 | head -100

Repository: gambitph/Stackable

Length of output: 5369

🏁 Script executed:

# Check for any other CSS rules targeting fs-header-actions or that might affect the button layout
rg -n "fs-header-actions|fs_account" src/welcome/admin.scss -A 3 -B 1

Repository: gambitph/Stackable

Length of output: 44

🏁 Script executed:

# Search for any existing CSS that might reset padding on Freemius elements
rg -n "padding.*0|padding-left.*0" src/welcome/admin.scss

Repository: gambitph/Stackable

Length of output: 880

🏁 Script executed:

# Check line 878 context to see what padding-left: 0 rule applies to
sed -n '870,885p' src/welcome/admin.scss

Repository: gambitph/Stackable

Length of output: 307

🏁 Script executed:

# Search more broadly for Freemius or account-related styling in the entire SCSS file
rg -n "fs-header-actions|#fs_account|\.wrap\s*{" src/welcome/admin.scss -A 5 | head -50

Repository: gambitph/Stackable

Length of output: 205

🏁 Script executed:

# Search for fs-header-actions or account-related styling without problematic regex
rg -n "fs-header-actions|#fs_account" src/welcome/admin.scss -A 5

Repository: gambitph/Stackable

Length of output: 44

🏁 Script executed:

# Look at the broader context around the body.toplevel_page_stackable block to see all nested rules
sed -n '432,912p' src/welcome/admin.scss | grep -n "fs-\|padding-left\|list-style"

Repository: gambitph/Stackable

Length of output: 318

🏁 Script executed:

# Get the full context of the body.toplevel_page_stackable block to see all ul-related rules
sed -n '432,450p' src/welcome/admin.scss

Repository: gambitph/Stackable

Length of output: 374

Consider also resetting padding-left for .fs-section ul.

The enclosing block's ul rule (lines 438–441) applies both list-style-type: circle and padding-left: 2em. This fix only resets list-style-type: none, leaving the 2em left padding intact. Since the Freemius action buttons are rendered as a horizontal list within .fs-section, the residual indentation could contribute to misalignment.

Add padding-left: 0; to the .fs-section ul rule:

 	.fs-section ul {
 		list-style-type: none;
+		padding-left: 0;
 	}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.fs-section ul {
list-style-type: none;
}
.fs-section ul {
list-style-type: none;
padding-left: 0;
}
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@src/welcome/admin.scss` around lines 442 - 444, The .fs-section ul rule
currently only resets list-style-type to none but leaves the enclosing ul's left
padding (previously set to 2em) intact, causing horizontal misalignment of
Freemius action buttons; update the .fs-section ul CSS rule to also reset the
left padding (add padding-left: 0) so the list is not indented and aligns
correctly.


.s-box {
background-color: #fff;
border-radius: 0;
Expand Down
Loading