Fix multiple macOS compatibility bugs#281
Open
sclarkca wants to merge 3 commits into
Open
Conversation
added 2 commits
May 16, 2026 12:49
- Change default disk stats to use root volume "/" instead of summing all volumes from /Volumes, which included external drives (fixes gao-sun#250) - Fix invalid NSRegularExpression pattern "/ +/g" (JS-style) to use Swift's split(separator:) directly
- Fix gao-sun#227: Parse top command rsize suffixes (K/M/G) correctly for memory process list display - Fix gao-sun#226: Handle network byte counter wrap without reporting 0 speed - Fix gao-sun#236: Add appearance mode to widget shared preferences so widgets follow eul's theme setting - Fix gao-sun#246: Set NSApp.appearance alongside window.appearance for consistent appearance switching - Fix gao-sun#271: Improve status bar visibility logic to avoid flickering on newer macOS versions - Fix deprecated OSXApplicationExtension → macOSApplicationExtension
- Filter ifconfig results to only physical interfaces (en*, ap*) - Prevent deadlock by adding timeout guard for async network callback - Fix TopStore memory parsing formatting - Remove SDKROOT=macosx from SwiftFormat build phase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several bugs related to newer macOS compatibility:
topcommandrsizesuffixes (K/M/G) correctly for memory process list display. On macOS Big Sur+,topoutputs human-readable sizes (e.g.2G,1024M) which were not parsed correctly, causing memory values to show in wrong unitsNSApp.appearancealongsidewindow.appearancefor consistent appearance switchingOSXApplicationExtension→macOSApplicationExtensionfor Xcode compatibilityFiles Changed
eul/Store/TopStore.swift- Parse rsize unit suffixes (K/M/G)eul/Store/NetworkStore.swift- Safer counter wrap handlingeul/Store/PreferenceStore.swift- Write appearance mode to widget containereul/AppDelegate.swift- Also set NSApp.appearanceeul/StatusBar/StatusBarManager.swift- Cleaner visibility logiceul/StatusBar/StatusBarItem.swift- Ensure button allocationSharedLibrary/Schema/PreferenceEntry.swift- Add appearanceMode fieldSharedLibrary/Schema/StandardProvider.swift- Fix deprecated API availabilityBatteryWidget/BatteryWidget.swift,CpuWidget/CpuWidget.swift,MemoryWidget/MemoryWidget.swift,NetworkWidget/NetworkWidget.swift- Apply preferred color scheme from preference