feat: Add automorphism group for antimagma#205
Closed
limakzi wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds functionality to compute the automorphism group of a magma structure. This feature implements a method to find all automorphisms (structure-preserving bijective mappings) of a given magma.
- Implements
MagmaAutomorphismGroupfunction that computes automorphisms by checking all permutations - Adds comprehensive documentation with usage examples
- Includes test coverage verifying automorphism properties
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/properties.gd | Declares the MagmaAutomorphismGroup attribute with documentation and examples |
| lib/properties.gi | Implements the automorphism group computation algorithm |
| tst/test_properties_magma_automorphism_group.tst | Adds tests verifying automorphism group properties |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
limakzi
changed the title
limakzi
force-pushed
the
feature/204-add-authomorphism-group
branch
from
October 13, 2025 21:23
0641e58 to
029f3e5
Compare
limakzi
force-pushed
the
feature/204-add-authomorphism-group
branch
from
June 29, 2026 21:38
029f3e5 to
f4e523f
Compare
|
|
||
| #! @Arguments M | ||
| #! @Description | ||
| #! computes automorphism group of antimagma <A>M</A>. |
Member
There was a problem hiding this comment.
missing "a" or "the" (twice)
Member
|
@limakzi please resolve conflicts |
Collaborator
Author
|
@olexandr-konovalov I will create new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially solves #204.