Draft
Replace RowDictWithCache with on-demand RowFromId to fix memory exhaustion#237
Conversation
…y exhaustion Co-authored-by: limakzi <50334623+limakzi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update implementation of Elias-Fano encoding based on feedback
Replace RowDictWithCache with on-demand RowFromId to fix memory exhaustion
Mar 6, 2026
limakzi
force-pushed
the
feature/change-encoding
branch
3 times, most recently
from
July 15, 2026 07:38
59de591 to
333d8a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RowDictWithCacheeagerly materialised all n^n possible rows at once — for n=8 that's 16,777,216 entries — making it unusable for even moderately large orders.Changes
lib/helper.gdRowDictWithCachewithRowFromId(row_id, n): computes a single row on demand using the existingPowersOfNWithCachehelper, no pre-allocation.MultiplicationTableDecode: callsRowFromIdper row instead of indexing into a precomputed dictionary.MultiplicationTableGetEntry: decodes the column entry directly without constructing any row intermediate, preserving O(1) access.tst/test_helper_multiplication_table_encoding.tst: replacedRowDictWithCachetests withRowFromIdtests covering row ID 0 (all-ones), max row ID n^n−1 (all-n), and intermediate IDs across multiple values of n.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.