Rubocop and Puppet <= 3.8.0

[spacepants]

Hey there,

The current gemset in the skeleton breaks Rubocop integration.

When using Rubocop 0.33.0 with any Puppet version, Rubocop fails with invalid option: -E.

Updating Rubocop to the latest 0.43.0 fails due to puppet's safe_yaml monkey patch which redefines the method with an arity of 3, while Rubocop's expecting it to have 5.

Right now as a workaround, I'm updating Rubocop to 0.43.0 and dropping rubocop from the test task if the Puppet version is <= 3.8 like so:

test_tasks = [ 
  :metadata_lint, 
  :syntax, 
  :lint, 
  :rubocop, 
  :spec, 
] 

if Puppet.version.to_f <= 3.8 
  test_tasks.delete(:rubocop) 
end 
desc "Run syntax, lint, and spec tests." 
task :test => test_tasks 

Is there a better approach I should be trying in order to fix things like test matrixes for Travis tests? I'm assuming that long-term the skeleton will eventually be updated to default to Puppet 4, but I'm not sure how far off that is.

Thanks!