Skip to content

Commit 9faf8c2

Browse files
garrytanclaude
andcommitted
docs(todos): fail-fast fork-PR secret detection in evals.yml
Filed from the PR #2211 full-checks run: fork shards burned 31m48s timing out on an empty ANTHROPIC_API_KEY before failing, and the contributor re-triggered the doomed run reading it as flakiness. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent a31f865 commit 9faf8c2

1 file changed

Lines changed: 26 additions & 0 deletions

File tree

TODOS.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,32 @@ a silent mistake breaks all 52 skills. High blast radius — needs its own focus
4545

4646
## Test infrastructure
4747

48+
### P3: Fail-fast fork-PR secret detection in evals.yml (filed via PR #2211 full-checks run)
49+
50+
**Priority:** P3
51+
52+
**What:** Add an early step to each eval shard in `.github/workflows/evals.yml` that
53+
detects a secretless run (fork PR: `secrets.ANTHROPIC_API_KEY` empty) and exits
54+
immediately with a clear "fork PR: eval secrets unavailable — see fork-PR workflow in
55+
CLAUDE.md" annotation instead of running tests into auth failures.
56+
57+
**Why:** On fork PR #2211, `e2e-review` failed in 1m with `error_api` and
58+
`e2e-pty-plan-smoke` burned 31m48s of runner time timing out on "Not logged in"
59+
before failing. The contributor read it as flakiness and re-triggered, burning the
60+
time twice. A 5-second preflight would have said exactly what was wrong.
61+
62+
**Pros:** Saves ~30+ min of Ubicloud runner time per fork-PR push; replaces a
63+
misleading red X with an actionable message; stops contributors re-triggering
64+
doomed runs.
65+
**Cons:** One more conditional per shard; must not mask a genuinely misconfigured
66+
base-repo secret (annotate differently when `github.event.pull_request.head.repo.fork`
67+
is false).
68+
69+
**Context / where to start:** `.github/workflows/evals.yml` matrix job — add a step
70+
before "Run <suite>" that checks the secret and `github.event.pull_request.head.repo.fork`,
71+
emits a `::notice` and exits 0 (or neutral). Diagnosis receipts: PR #2211 run 29056479216,
72+
jobs 86249027242 (empty `ANTHROPIC_API_KEY`, `error_api`) and 86249027265 (login timeout).
73+
4874
### Eval harness: live progress + incremental result persistence (kill the silent hour)
4975

5076
**Priority:** P1

0 commit comments

Comments
 (0)