fix(browse): respect GSTACK_CHROMIUM_PATH in headless mode#1035
fix(browse): respect GSTACK_CHROMIUM_PATH in headless mode#1035mvanhorn wants to merge 1 commit into
Conversation
GSTACK_CHROMIUM_PATH was only read in launchHeaded() but not in launch(). Skills like /qa that use headless mode ignored the env var, breaking browse on NixOS and other non-FHS distros where the bundled chromium_headless_shell binary fails. Read the env var in launch() the same way launchHeaded() does and pass it as executablePath to chromium.launch(). Fixes garrytan#906
|
This specific headless Given that, I would treat #1642 as the canonical shipped fix for the browser-manager part of this PR. If issue #906 still has a remaining setup/install angle, it likely needs a fresh narrow PR against current |
|
Good catch @jbetala7 — confirmed |
Summary
GSTACK_CHROMIUM_PATHis only respected inlaunchHeaded()(browser-manager.ts:270) but not inlaunch()(browser-manager.ts:183). Skills like/qause headless mode by default, so settingGSTACK_CHROMIUM_PATHhas no effect when the bundledchromium_headless_shellfails on NixOS and other non-FHS distros.Changes
Read
GSTACK_CHROMIUM_PATHinlaunch()and pass it asexecutablePathtochromium.launch(), matching the existing pattern inlaunchHeaded().browse/src/browser-manager.ts: 3 lines added.Testing
bun testpasses (665 pass across skill validation and gen-skill-docs). The change mirrors the existing env var handling inlaunchHeaded()at line 270.Fixes #906
This contribution was developed with AI assistance (Claude Code).