Skip to content

[codex] Fix make-pdf browse resolution#1113

Draft
parafallen-maker wants to merge 1 commit intogarrytan:mainfrom
parafallen-maker:codex/fix-make-pdf-browse-resolution
Draft

[codex] Fix make-pdf browse resolution#1113
parafallen-maker wants to merge 1 commit intogarrytan:mainfrom
parafallen-maker:codex/fix-make-pdf-browse-resolution

Conversation

@parafallen-maker
Copy link
Copy Markdown

Summary

  • Resolve browse from Codex/agents installs before older Claude install paths
  • Reject executable directories when resolving the browse binary
  • Avoid about:blank in make-pdf setup so the Chromium smoke check works with the browse URL allowlist
  • Default generated PDFs and setup smoke-test output to /private/tmp on macOS so browse can write them
  • Add a regression test for executable directories being mistaken for binaries

Root cause

On macOS, directories commonly have execute permission. resolveBrowseBin() only checked X_OK, so a directory such as ~/.agents/skills/browse could be selected as the browse binary. In Codex installs, the active browse binary also lives under ~/.agents/skills/gstack, while the previous global fallback only checked ~/.claude.

Validation

  • bun test make-pdf/test
    • 75 pass, 1 skip, 0 fail
    • skip: local pdftotext is not installed; runtime PDF generation does not require it
  • make-pdf/dist/pdf setup
    • browse binary resolved to ~/.agents/skills/gstack/browse/dist/browse
    • Chromium smoke check passed
    • smoke-test PDF generated under /private/tmp

@parafallen-maker parafallen-maker force-pushed the codex/fix-make-pdf-browse-resolution branch from 08d72c8 to 9daff79 Compare April 21, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant