[codex] Fix make-pdf browse resolution#1113
Draft
parafallen-maker wants to merge 1 commit intogarrytan:mainfrom
Draft
[codex] Fix make-pdf browse resolution#1113parafallen-maker wants to merge 1 commit intogarrytan:mainfrom
parafallen-maker wants to merge 1 commit intogarrytan:mainfrom
Conversation
08d72c8 to
9daff79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
about:blankinmake-pdf setupso the Chromium smoke check works with the browse URL allowlist/private/tmpon macOS so browse can write themRoot cause
On macOS, directories commonly have execute permission.
resolveBrowseBin()only checkedX_OK, so a directory such as~/.agents/skills/browsecould be selected as the browse binary. In Codex installs, the active browse binary also lives under~/.agents/skills/gstack, while the previous global fallback only checked~/.claude.Validation
bun test make-pdf/testpdftotextis not installed; runtime PDF generation does not require itmake-pdf/dist/pdf setup~/.agents/skills/gstack/browse/dist/browse/private/tmp