fix(office-hours): output full design doc inline before approval prompt#1116
Open
RyanAlberts wants to merge 1 commit intogarrytan:mainfrom
Open
fix(office-hours): output full design doc inline before approval prompt#1116RyanAlberts wants to merge 1 commit intogarrytan:mainfrom
RyanAlberts wants to merge 1 commit intogarrytan:mainfrom
Conversation
Closes garrytan#879. When Phase 5 finishes the design doc and asks for approval via AskUserQuestion, users currently cannot see the doc content — Bash `cat` and Read tool outputs are often collapsed in the Claude Code UI, so the user ends up approving a document they have not actually read and has to repeatedly ask "show me the full doc" to unblock the decision. Add an explicit instruction in the office-hours Phase 5 template to print the complete design doc as direct assistant text (not via a tool call) before presenting the Approve / Revise / Start over question. Assistant messages render reliably, so the user can actually review the doc at the moment of approval. Edits the template (SKILL.md.tmpl); SKILL.md regenerated via `bun run gen:skill-docs --host all`. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #879.
Problem
When
/office-hoursfinishes Phase 5 (Design Doc) and asks the user for approval viaAskUserQuestion, the user often cannot see the document content. Tool outputs (e.g.Bash cat,Read) are frequently collapsed in the Claude Code UI, so the design doc the skill just wrote is effectively invisible at the exact moment the user has to approve / revise / start over. The current flow leaves users repeatedly asking "show me the full doc" before they can decide.Fix
Add an explicit instruction in the office-hours Phase 5 template, placed immediately after
{{SPEC_REVIEW_LOOP}}and immediately before the Approve / Revise / Start overAskUserQuestion:Assistant messages render reliably, so the user can actually read the doc at the moment of approval.
Scope
office-hours/SKILL.md.tmpl(the source of truth).office-hours/SKILL.mdviabun run gen:skill-docs --host all.Diff stat
Test plan
bun run gen:skill-docs --host allcompletes cleanly and updatesoffice-hours/SKILL.mdto match the new template text at the Phase 5 approval step./office-hourssession on a real project — confirm the assistant prints the full design doc inline before the Approve / Revise / Start over question.Made with Cursor