Skip to content

fix(office-hours): output full design doc inline before approval prompt#1116

Open
RyanAlberts wants to merge 1 commit intogarrytan:mainfrom
RyanAlberts:fix/879-office-hours-inline-design-doc
Open

fix(office-hours): output full design doc inline before approval prompt#1116
RyanAlberts wants to merge 1 commit intogarrytan:mainfrom
RyanAlberts:fix/879-office-hours-inline-design-doc

Conversation

@RyanAlberts
Copy link
Copy Markdown

Closes #879.

Problem

When /office-hours finishes Phase 5 (Design Doc) and asks the user for approval via AskUserQuestion, the user often cannot see the document content. Tool outputs (e.g. Bash cat, Read) are frequently collapsed in the Claude Code UI, so the design doc the skill just wrote is effectively invisible at the exact moment the user has to approve / revise / start over. The current flow leaves users repeatedly asking "show me the full doc" before they can decide.

Fix

Add an explicit instruction in the office-hours Phase 5 template, placed immediately after {{SPEC_REVIEW_LOOP}} and immediately before the Approve / Revise / Start over AskUserQuestion:

Before asking for approval, output the full design doc inline.

Print the complete contents of the design doc as direct assistant text in the conversation — do NOT ask the user to open the file, and do NOT rely on a Bash cat or Read tool call to show it. Tool outputs are frequently collapsed in the Claude Code UI, which leaves the user approving a document they cannot actually see. The one place the full doc is guaranteed to render is the assistant message itself.

Format: a short preamble (`Here is the design doc saved to {path} — please review before approving:`) followed by the verbatim document body. Then proceed to the AskUserQuestion below.

Assistant messages render reliably, so the user can actually read the doc at the moment of approval.

Scope

  • Edit office-hours/SKILL.md.tmpl (the source of truth).
  • Regenerate office-hours/SKILL.md via bun run gen:skill-docs --host all.
  • No code, no tests, no other skills touched.

Diff stat

 office-hours/SKILL.md      | 13 +++++++++++++
 office-hours/SKILL.md.tmpl | 13 +++++++++++++
 2 files changed, 26 insertions(+)

Test plan

  • bun run gen:skill-docs --host all completes cleanly and updates office-hours/SKILL.md to match the new template text at the Phase 5 approval step.
  • Next /office-hours session on a real project — confirm the assistant prints the full design doc inline before the Approve / Revise / Start over question.

Made with Cursor

Closes garrytan#879.

When Phase 5 finishes the design doc and asks for approval via
AskUserQuestion, users currently cannot see the doc content — Bash `cat`
and Read tool outputs are often collapsed in the Claude Code UI, so the
user ends up approving a document they have not actually read and has to
repeatedly ask "show me the full doc" to unblock the decision.

Add an explicit instruction in the office-hours Phase 5 template to
print the complete design doc as direct assistant text (not via a tool
call) before presenting the Approve / Revise / Start over question.
Assistant messages render reliably, so the user can actually review
the doc at the moment of approval.

Edits the template (SKILL.md.tmpl); SKILL.md regenerated via
`bun run gen:skill-docs --host all`.

Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

office-hours: design doc not visible to user when AskUserQuestion requests approval

2 participants