fix(docs): match README manual-uninstall snippet to install layout#1142
Open
mvanhorn wants to merge 1 commit intogarrytan:mainfrom
Open
fix(docs): match README manual-uninstall snippet to install layout#1142mvanhorn wants to merge 1 commit intogarrytan:mainfrom
mvanhorn wants to merge 1 commit intogarrytan:mainfrom
Conversation
The manual-removal step 2 used `find -maxdepth 1 -type l` which only matches top-level symlinks. But setup creates real directories per skill with SKILL.md symlinked into gstack/, so nothing ever matched and the per-skill directories survived uninstall. Switches to iterating real directories and checking each nested SKILL.md target. Matches the real install topology and aligns with the fix to bin/gstack-uninstall in garrytan#902. Fixes garrytan#1130
dgrant
approved these changes
Apr 22, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The manual-removal block in README.md told users to run:
setup(lines 399-404) creates each skill as a real directory at the top level withSKILL.mdas a nested symlink.-maxdepth 1 -type lonly matches top-level symlinks, so thisfindmatched nothing on current installs and users were left with ~30 empty per-skill directories.Fix
Replace the snippet with one that iterates real directories, skips
gstackitself, checks the nestedSKILL.mdis a symlink pointing intogstack/, and removes the directory if so.Verified on a fake HOME:
Sibling fix for the same root cause in
bin/gstack-uninstallis in #902.Fixes #1130