docs(readme): align manual uninstall with --keep-state split#1143
Open
mvanhorn wants to merge 1 commit intogarrytan:mainfrom
Open
docs(readme): align manual uninstall with --keep-state split#1143mvanhorn wants to merge 1 commit intogarrytan:mainfrom
mvanhorn wants to merge 1 commit intogarrytan:mainfrom
Conversation
The bin/gstack-uninstall script already has --keep-state, which removes skills but preserves ~/.gstack/ (config, analytics, sessions, project history, installation-id). The manual-removal block in README didn't reflect that split; it dropped rm -rf ~/.gstack inline as step 4 alongside the skill cleanup, so users following the manual path always lost their state even when the scripted path lets them keep it. Labels the numbered block as the --keep-state equivalent and moves the ~/.gstack purge into an "Also purge gstack data (optional)" subsection. Same behaviour available, just documented as two choices. No script changes. Fixes garrytan#1131
dgrant
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
bin/gstack-uninstallscript already supports--keep-state, which removes skills but preserves~/.gstack/(config, analytics, sessions, project history, installation-id). The manual-removal block in README didn't reflect that split: it droppedrm -rf ~/.gstackinline as step 4 alongside the skill cleanup, so users following the manual path always lost their state even when the scripted path lets them keep it.Reported in #1131.
Fix
--keep-stateequivalent.~/.gstackpurge into an "Also purge gstack data (optional)" subsection after the block, so users can decide whether to run it.No script changes. Same behaviour is available, just documented as two choices instead of one.
Diff
Also purge gstack data (optional)
~/.gstack/holds config, analytics, sessions, project history, and thegstack-uninstallwithout--keep-state):