fix(browse): enable Chromium sandbox in headed mode#1551
Closed
GolfFry wants to merge 1 commit into
Closed
Conversation
The two headed launchPersistentContext() call sites in BrowserManager omitted the chromiumSandbox option, so Playwright defaulted to passing --no-sandbox even on macOS and Linux where the sandbox works correctly. Chromium then displays the yellow "unsupported command-line flag — security will suffer" info bar, and any renderer exploit (V8, Skia, libwebp, …) can escape straight to the user's account. The headless launch() path at line 179 already passes `chromiumSandbox: process.platform !== 'win32'`. This brings the two headed sites in line — preserving the Windows exemption (where the Bun→Node spawn chain breaks the sandbox, per GitHub garrytan#276). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two headed launchPersistentContext() call sites in BrowserManager omitted the chromiumSandbox option, so Playwright defaulted to passing --no-sandbox even on macOS and Linux where the sandbox works correctly. Chromium then displays the yellow "unsupported command-line flag — security will suffer" info bar, and any renderer exploit (V8, Skia, libwebp, …) can escape straight to the user's account.
The headless launch() path at line 179 already passes
chromiumSandbox: process.platform !== 'win32'. This brings the two headed sites in line — preserving the Windows exemption (where the Bun→Node spawn chain breaks the sandbox, per GitHub #276).