v1.59.1.0 fix(deps): bump diff to ^9.0.0 to clear GHSA-73rr-hh4g-fpgx (#1588)#1599
Open
genisis0x wants to merge 2 commits into
Open
v1.59.1.0 fix(deps): bump diff to ^9.0.0 to clear GHSA-73rr-hh4g-fpgx (#1588)#1599genisis0x wants to merge 2 commits into
genisis0x wants to merge 2 commits into
Conversation
genisis0x
force-pushed
the
fix/1588-diff-dep-bump-v9
branch
from
a960cbe to
e4e300e
Compare
genisis0x
force-pushed
the
fix/1588-diff-dep-bump-v9
branch
from
e4e300e to
b0277b2
Compare
github-actions
Bot
changed the title
genisis0x
force-pushed
the
fix/1588-diff-dep-bump-v9
branch
2 times, most recently
from
e9be514 to
860df34
Compare
…#1588) `npm audit` flags diff@7.0.0 with a low-severity DoS in parsePatch/applyPatch (GHSA-73rr-hh4g-fpgx, affected 6.0.0–8.0.2, fixed in 9.0.0). gstack uses diff against local content the user controls so practical risk is low, but the advisory surfaces on every audit pass and blocks clean supply-chain runs for users vendoring gstack. The 9.0.0 breaking changes only touch parsePatch / applyPatch / createPatch and the ESM/CJS exports. Both call sites in this repo (browse/src/snapshot.ts:568, browse/src/meta-commands.ts:712) use `Diff.diffLines`, whose signature and return shape are unchanged in v9, so this is a no-op at runtime.
…-gate Base VERSION advanced to 1.58.1.0, level with this branch, so the version gate failed its 'VERSION must be greater than base' rule. Bump VERSION and package.json to 1.59.1.0 — the next free slot above the queued 1.59.0.0 (garrytan#1815). The diff ^9.0.0 dependency bump is unchanged; the only consumer (Diff.diffLines in browse) is API-compatible with jsdiff v9.
genisis0x
force-pushed
the
fix/1588-diff-dep-bump-v9
branch
from
860df34 to
aa77594
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1588.
Summary
npm auditflagsdiff@7.0.0with a low-severity DoS inparsePatch/applyPatch(GHSA-73rr-hh4g-fpgx, affected 6.0.0–8.0.2, fixed in 9.0.0). gstack usesdiffagainst local content the user controls so practical risk is low, but the advisory shows on every audit pass and blocks clean supply-chain runs for users who vendor gstack.Compatibility check
diff@9's breaking changes only touchparsePatch/applyPatch/createPatchand the ESM/CJS exports. Call sites in this repo:browse/src/snapshot.ts:568—Diff.diffLines(lastSnapshot, snapshotText)browse/src/meta-commands.ts:712—Diff.diffLines(text1, text2)diffLinessignature + return shape are unchanged in v9, so no runtime impact. Smoke-tested locally:Test plan
bun install— clean resolve, single package updatedbun test— same pre-existingsidebar-ux.test.tsfailures as main (unrelated; tests grep server.ts for symbols already removed); no new failures introducedDiff.diffLinesround-trip against v9 confirmed identical outputHappy to bundle this into the next fix wave or land standalone, whichever's lighter on your end.