Fix Codex skill loading errors from unquoted descriptions#1739
Fix Codex skill loading errors from unquoted descriptions#1739GilbertzzzZZ wants to merge 2 commits into
Conversation
|
Independent validation — this looks correct and fixes a real, reproducible bug. Reproduced on The offending generated line is: description: Design consultation: understands your product, researches the landscape, ... and (gstack)The trimmed lead starts with With this PR's branch: the same sweep reports One heads-up for the maintainer, not a blocker: this overlaps file-wise with the in-flight wave #1740, which regenerates ~56 |
Apply the YAML-quoting generator fix to spec/SKILL.md, which arrived via garrytan#1740 merge with an unquoted description that would have re-broken Codex skill loading. Why: jbetala7 flagged in garrytan#1739 review that garrytan#1740 would land first without touching scripts/gen-skill-docs.ts, reintroducing the bug. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Thanks @jbetala7 for the independent repro and the heads-up about #1740 — really appreciated. Following your note: #1740 has since landed on main. I've merged main into this branch and regenerated @garrytan — this is unblocked and ready to merge whenever you have a moment. Conflict-free against main, generator fix + regenerated files in one PR. |
|
Reproduced on Codex 0.134.0 (fresh |
Apply the YAML-quoting generator fix to spec/SKILL.md, which arrived via garrytan#1740 merge with an unquoted description that would have re-broken Codex skill loading. Why: jbetala7 flagged in garrytan#1739 review that garrytan#1740 would land first without touching scripts/gen-skill-docs.ts, reintroducing the bug. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
7bc4d41 to
7a8a1e5
Compare
Summary
This PR fixes Codex skill loading failures caused by generated
SKILL.mdfrontmatter descriptions that become invalid YAML after catalog trimming.When gstack is loaded by Codex, affected skills can be skipped with warnings like:
The root cause is that the generator converts long block-scalar descriptions into one-line inline YAML values, but some descriptions contain
:. Without quoting, YAML can parse that colon as a mapping delimiter.Example
Before:
After:
Changes
descriptionvalues inscripts/gen-skill-docs.tsso Codex can parse generated skill frontmatter safely.SKILL.mdfiles.claude-ship-SKILL.mdgolden fixture.Validation
bun run gen:skill-docs --host all --dry-runSKILL.mdfilesgit diff --checkbun testNote: the existing
shiptoken ceiling warning still appears during generation, but the command exits successfully and is unrelated to this Codex YAML loading fix.Contribution context
Thank you to the gstack team for building and maintaining this project. I have benefited a lot from using it.
Claude Code is still my primary agent environment, but because my team needs it, I am starting to use Codex as well. In my own projects, I am also beginning to support both Claude Code and Codex at the same time.
I would be happy to keep contributing compatibility fixes for using the gstack skill series from Codex in the future.