Skip to content

v1.54.1.0 Fix generated skill YAML frontmatter#1752

Open
cathrynlavery wants to merge 10 commits into
garrytan:mainfrom
cathrynlavery:fix/skill-frontmatter-validation
Open

v1.54.1.0 Fix generated skill YAML frontmatter#1752
cathrynlavery wants to merge 10 commits into
garrytan:mainfrom
cathrynlavery:fix/skill-frontmatter-validation

Conversation

@cathrynlavery
Copy link
Copy Markdown
Contributor

Summary

  • quote catalog-trimmed generated skill descriptions so colon-containing descriptions remain valid YAML
  • add a frontmatter-only validation script and wire it into the skill docs workflow
  • add regression coverage for SKILL.md frontmatter validation

Verification

  • bun test test/skill-validation.test.ts test/catalog-trim.test.ts
  • bun run gen:skill-docs --dry-run
  • bun run gen:skill-docs --host codex
  • bun run gen:skill-docs --host factory
  • bun run skill:frontmatter
  • bun run gen:skill-docs --host all
  • bun test test/gen-skill-docs.test.ts

@cathrynlavery
Copy link
Copy Markdown
Contributor Author

Pushed 493008f to address the stale-version gate.

Fix:

  • Bumped VERSION and package.json from 1.48.0.0 to the queue-recommended 1.51.1.0.

Verification:

  • git diff --check
  • bun run scripts/compare-pr-version.ts next.json "1752" (the local script emitted could not parse util output; failing open, but exited 0)

Remaining remote blocker:

  • build-image is failing after a successful Docker build because GitHub cannot push ghcr.io/garrytan/gstack/ci:*: denied: installation not allowed to Write organization package. That looks like GitHub package permission/Actions token scope on the upstream org, not an application-code failure.

@cathrynlavery cathrynlavery changed the title Fix generated skill YAML frontmatter v1.51.1.0 Fix generated skill YAML frontmatter May 27, 2026
@cathrynlavery
Copy link
Copy Markdown
Contributor Author

Hourly PR readiness sweep resolved the merge conflict with current garrytan/gstack:main and pushed normal merge commit 2e8caafa to the Cathryn-authored head branch.\n\nValidation run locally:\n- bun run skill:frontmatter — validated 53 SKILL.md files.\n\nRechecking GitHub merge/check status now.

@cathrynlavery
Copy link
Copy Markdown
Contributor Author

cathrynlavery commented May 28, 2026

Hourly PR readiness sweep rechecked the remaining red CI.

Blocker is workflow/package permissions, not a code/test failure in this PR:

All other checks on the PR are green. Needs GHCR/package write permission or workflow permission adjustment by repo/org maintainers.

Correction note: the immediately previous sweep comment had shell-backtick expansion strip the inline code; this comment has the intact evidence.

@cathrynlavery
Copy link
Copy Markdown
Contributor Author

Hourly PR readiness sweep resolved the new merge conflict with current garrytan/gstack:main and pushed normal merge commit 86af673c to the Cathryn-authored head branch.

Resolution:

  • Kept upstream/main's current 1.52.0.0 version in VERSION and package.json while preserving this PR's frontmatter fixes.

Validation:

  • git diff --check
  • bun run skill:frontmatter — validated 53 SKILL.md files.

Known remaining remote blocker is still the GHCR/package permission failure on build-image, not a code/test failure.

@cathrynlavery
Copy link
Copy Markdown
Contributor Author

Bumped VERSION to 1.52.1.0 to clear the version gate (base is 1.52.0.0; CI suggested 1.52.1.0). Validation: bun install --frozen-lockfile; bun run scripts/detect-bump.ts 1.52.0.0 1.52.1.0; git diff --check. Note: the remaining build-image failure in the prior run was an organization package permission error: denied: installation not allowed to Write organization package, which looks infra/permissions-side rather than code.

@cathrynlavery cathrynlavery changed the title v1.51.1.0 Fix generated skill YAML frontmatter v1.52.1.0 Fix generated skill YAML frontmatter May 29, 2026
@cathrynlavery cathrynlavery changed the title v1.52.1.0 Fix generated skill YAML frontmatter v1.52.2.0 Fix generated skill YAML frontmatter May 29, 2026
@cathrynlavery
Copy link
Copy Markdown
Contributor Author

Hourly PR readiness sweep pushed 34c87979 to clear the current version-slot collision.

Fix:

Validation:

  • git diff --check
  • bun install --frozen-lockfile
  • bun run scripts/detect-bump.ts 1.52.0.0 1.52.2.0patch

Remaining non-code blocker, if it persists on rerun: build-image is failing while pushing GHCR with denied: installation not allowed to Write organization package, which needs repo/package workflow permissions rather than a PR code change.

@cathrynlavery
Copy link
Copy Markdown
Contributor Author

Follow-up pushed a8551211 to merge current main into this PR and resolve the VERSION conflict.

Resolution:

  • Kept upstream/main's new 1.52.1.0 base.
  • Preserved this PR's next-slot bump to 1.52.2.0.

Validation:

  • git diff --check
  • bun install --frozen-lockfile
  • bun run scripts/detect-bump.ts 1.52.1.0 1.52.2.0patch

@cathrynlavery cathrynlavery changed the title v1.52.2.0 Fix generated skill YAML frontmatter v1.52.3.0 Fix generated skill YAML frontmatter May 29, 2026
@cathrynlavery
Copy link
Copy Markdown
Contributor Author

Follow-up pushed de1e5adc after the version gate reported a new collision: PR #1787 now claims v1.52.2.0.

Fix:

  • Moved this PR to VERSION=1.52.3.0.
  • Updated the PR title to v1.52.3.0 Fix generated skill YAML frontmatter.

Validation:

  • git diff --check
  • bun install --frozen-lockfile
  • bun run scripts/detect-bump.ts 1.52.1.0 1.52.3.0patch

@cathrynlavery
Copy link
Copy Markdown
Contributor Author

Hourly PR readiness sweep pushed a14c3f34d91a to resolve the latest merge conflict with garrytan/gstack:main.

Resolution:

  • Merged current origin/main into the PR branch.
  • Kept upstream/main’s new 1.52.2.0 base changes.
  • Preserved this PR’s next patch slot as VERSION=1.52.3.0 and package.json version 1.52.3.0.

Validation:

  • git diff --check
  • bun install --frozen-lockfile
  • bun run scripts/detect-bump.ts 1.52.2.0 1.52.3.0patch
  • bun run skill:frontmatter → validated 53 SKILL.md files

CI is re-running on the pushed head. The prior non-code blocker was the GHCR/package permission failure in build-image; if it persists, repo/org package permissions still need maintainer attention.

@cathrynlavery
Copy link
Copy Markdown
Contributor Author

CI blocker is infra/permissions, not a code failure from this PR: build-image successfully builds the image, then fails while pushing to GHCR with:

denied: installation not allowed to Write organization package

Run: https://github.com/garrytan/gstack/actions/runs/26671168660/job/78614548296

No code change pushed; this needs GitHub Actions/package write permission or workflow token/package settings adjusted by a repo/org admin.

@cathrynlavery cathrynlavery changed the title v1.52.3.0 Fix generated skill YAML frontmatter v1.54.1.0 Fix generated skill YAML frontmatter May 30, 2026
@cathrynlavery
Copy link
Copy Markdown
Contributor Author

Hourly PR readiness sweep pushed 0cfba27 to resolve the latest merge conflict with garrytan/gstack:main.

Resolution:

  • Merged current origin/main into the Cathryn-authored PR branch.
  • Kept upstream/main's 1.54.0.0 base changes.
  • Preserved this PR's next patch slot as VERSION=1.54.1.0 and package.json version 1.54.1.0.
  • Updated the PR title to match v1.54.1.0.

Validation:

  • git diff --check
  • bun install --frozen-lockfile
  • bun run scripts/detect-bump.ts 1.54.0.0 1.54.1.0 → patch
  • bun run skill:frontmatter → validated 53 SKILL.md files.

Known non-code blocker if it persists on rerun: build-image has previously failed while pushing GHCR with a package permission error, not a PR code/test failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant