Skip to content

update skills#1857

Open
dxiao2003 wants to merge 1 commit into
garrytan:mainfrom
dxiao2003:pre-build-steps
Open

update skills#1857
dxiao2003 wants to merge 1 commit into
garrytan:mainfrom
dxiao2003:pre-build-steps

Conversation

@dxiao2003
Copy link
Copy Markdown

add check during eng review to make sure we have basics like environment defined in the spec

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Jun 4, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@buddy7599bot
Copy link
Copy Markdown

Heads-up on a likely conflict: this PR and the open #1812 (fix(plan-eng-review): add substrate-neutral platform-capability check) both edit plan-eng-review/SKILL.md and plan-eng-review/SKILL.md.tmpl to insert a new pre-review prerequisite/capability section. They overlap thematically (both gate the review on environment/platform basics) and will conflict on those two files once either merges.

The numbering cleanup here is also legit and worth keeping: section 905-ff currently has two items numbered 5. (TODOS cross-reference and Completeness check); this PR renumbers Completeness→6 and Distribution→7. If #1812 doesn't already do that, this is the canonical place for it.

Suggest the two get sequenced and reconciled — ideally one PR adds the prerequisites/capability checks and the other rebases on top — rather than landing both independently. Also: this only touches the tracked SKILL.md + .tmpl; please double-check check-freshness passes (the generator should keep them in sync) so CI doesn't flag drift. A more descriptive PR title than "update skills" would help maintainer triage too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants