fix: resolve Claude hook paths without CLAUDE_SKILL_DIR#1873
Open
maxpetrusenkoagent wants to merge 1 commit into
Open
fix: resolve Claude hook paths without CLAUDE_SKILL_DIR#1873maxpetrusenkoagent wants to merge 1 commit into
maxpetrusenkoagent wants to merge 1 commit into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
9ac91ea to
08f66bd
Compare
Author
|
Addressed second Codex reviewer blocker. Reviewer finding:
Fix:
New regression coverage:
Verification:
|
Author
|
Codex autoreview pass: CLEAN. Reviewer scope:
Verdict:
Verification already run:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes skill-frontmatter PreToolUse hook commands that depended on
CLAUDE_SKILL_DIR, which Claude Code 2.1.x does not populate for these hooks.This avoids replacing one env assumption with another:
.claude/skills/gstack/...first, coveringsetup --local$HOME/.claude/skills/gstack/..., covering global installsAffected hook surfaces:
carefulfreezeguardinvestigateVerification
ulimit -n 4096; bun test test/gen-skill-docs.test.ts391 pass, 0 failReview Context
Supersedes the closed duplicate attempt in #1872 and addresses the same root issue discussed in #1141 without depending on either
CLAUDE_SKILL_DIRorCLAUDE_PLUGIN_ROOT.