Skip to content

fix(browse): clean stale SingletonLock in handoff() before relaunch #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasonm-max wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

fix(browse): clean stale SingletonLock in handoff() before relaunch #2311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions browse/src/browser-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1551,7 +1551,6 @@ export class BrowserManager {
let newContext: BrowserContext;
try {
const fs = require('fs');
const path = require('path');
const extensionPath = this.findExtensionPath();
const { STEALTH_LAUNCH_ARGS, buildGStackLaunchArgs } = await import('./stealth');
// Same blink-level stealth flags as launch()/launchHeaded(). Without
Expand All @@ -1568,9 +1567,18 @@ export class BrowserManager {
console.log('[browse] Handoff: extension not found — headed mode without side panel');
}

const userDataDir = path.join(process.env.HOME || '/tmp', '.gstack', 'chromium-profile');
const userDataDir = resolveChromiumProfile();
fs.mkdirSync(userDataDir, { recursive: true });

// Pre-launch cleanup of stale SingletonLock/Socket/Cookie, same as
// launchHeaded(). Without this, a prior hard-killed/crashed headed
// session leaves lockfiles pointing at a dead PID; Chromium's
// ProcessSingleton then silently hands off startup to the (dead or
// zombie) old process instead of launching cleanly, and the new
// process exits shortly after — which reads as a clean disconnect
// and takes the whole daemon down with it.
cleanSingletonLocks(userDataDir);

// T1: same automation-tell-stripping defaults as launchHeaded().
// The handoff path (headless → headed re-launch) takes the same
// anti-detection posture.
Expand Down