s

silverchris · silverchris · commit 324dc555b56b · 2020-11-08T22:09:45.000-05:00
diff --git a/mazda/wireless/wireless.cpp b/mazda/wireless/wireless.cpp
@@ -146,9 +146,10 @@ void BCAClient::ConnectionStatusResp(
         const ::DBus::Struct <std::vector<uint8_t>> &terminalPath) {
     if (serviceId == 15) {
         char *pty = (char *) malloc(terminalPath._1.size());
-        std::strncpy(pty, (char *) &terminalPath._1.begin(), terminalPath._1.size());
+        std::copy(terminalPath._1.begin(), terminalPath._1.end(), pty);
         logd("\tPTY: %s\n", pty);
         handle_connect(pty);
+        free(pty);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -146,9 +146,10 @@ void BCAClient::ConnectionStatusResp(`
`146`	`146`	`const ::DBus::Struct <std::vector<uint8_t>> &terminalPath) {`
`147`	`147`	`if (serviceId == 15) {`
`148`	`148`	`char pty = (char ) malloc(terminalPath._1.size());`
`149`		`- std::strncpy(pty, (char *) &terminalPath._1.begin(), terminalPath._1.size());`
	`149`	`+ std::copy(terminalPath._1.begin(), terminalPath._1.end(), pty);`
`150`	`150`	`logd("\tPTY: %s\n", pty);`
`151`	`151`	`handle_connect(pty);`
	`152`	`+ free(pty);`
`152`	`153`	`}`
`153`	`154`	`}`
`154`	`155`