Skip to content

[pull] main from bazel-contrib:main#254

Merged
pull[bot] merged 3 commits intogarymm:mainfrom
bazel-contrib:main
Apr 29, 2025
Merged

[pull] main from bazel-contrib:main#254
pull[bot] merged 3 commits intogarymm:mainfrom
bazel-contrib:main

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented Apr 29, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

rickeylev and others added 3 commits April 29, 2025 03:07
…uation (#2827)

Right now, if two strings are compared, it results in an error.

Per spec, strings are suppose to "use the python behavior". Starlark is
going
to use Java semantics underneath, but it should behave close enough for
the (almost
exclusively) ASCII input that will be used.

Work towards #2826
While figuring out an upgrade from an old rules_python version, I had to
look up when the
environment variable first became available.

Also note what version it defaulted to 1.
Summary:
- Better handle git references for sdists.
- Better handle direct whl references.
- Add an extra test that turned out to be not needed in the end, but I
  left it to increase the code coverage.

Work towards #2363
Fixes #2828
@pull pull Bot added the ⤵️ pull label Apr 29, 2025
@pull pull Bot merged commit a79bbfa into garymm:main Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants