[pull] main from bazel-contrib:main#311
Merged
pull[bot] merged 2 commits intogarymm:mainfrom Jun 22, 2025
Merged
Conversation
…e relative to the package path (#2865) When `# gazelle:python_generation_mode package` is enabled, relative imports are currently not being added to the `deps` field of the generated target. For example, given the following Python code: ``` from .library import add as _add from .library import divide as _divide from .library import multiply as _multiply from .library import subtract as _subtract ``` The expected py_library rule should include a dependency on the local library package: ``` py_library( name = "py_default_library", srcs = ["__init__.py"], visibility = ["//visibility:public"], deps = [ "//example/library:py_default_library", ], ) ``` However, the actual generated rule is missing the deps entry: ``` py_library( name = "py_default_library", srcs = ["__init__.py"], visibility = ["//visibility:public"], ) ``` This change updates file_parser.go to ensure that relative imports (those starting with a .) are parsed and preserved. In `Resolve()`, logic is added to correctly interpret relative paths: A single dot (.) refers to the current package. Multiple dots (.., ..., etc.) traverse up parent directories. The relative import is resolved against the current label.Pkg path that imports the module and converted into an path relative to the root before dependency resolution. As a result, dependencies for relative imports are now correctly added to the deps field in package generation mode. Added a directive `# gazelle:experimental_allow_relative_imports true` to allow this feature to be opt in. --------- Co-authored-by: yushan <yushan@uber.com> Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com> Co-authored-by: Douglas Thor <dougthor42@users.noreply.github.com>
…rs (#2997) Fixes `bazel vendor` support for requirements files that contain environment markers. During a vendored `bazel build`, when evaluate_markers_py() is run it needs PYTHONHOME set to properly find the home of the vendored libraries. Resolves #2996 --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )