[pull] main from bazel-contrib:main#344
Merged
Merged
Conversation
Closes #2985 Suppose invalid `experimental_index_url_overrides` in `pip.parse` is set like below. ```bzl pip.parse( experimental_index_url = "https://pypi.org/simple", experimental_index_url_overrides = {"mypy": "https://invalid.com"}, hub_name = "pypi", requirements_lock = "//:requirements_lock.txt", ) ``` It fails as follows, showing only "pypi.org" as pypi index url, not "invalid.com" for for `mypy` package. ``` Error in fail: Failed to download metadata for ["mypy"] for from urls: ["https://pypi.org/simple"]. If you would like to skip downloading metadata for these packages please add 'simpleapi_skip=["mypy"]' to your 'pip.parse' call. ``` To show overridden url for each package, show url of each package that has been failed to download metadata. The error message with this PR is like below. ``` Error in fail: Failed to download metadata of the following packages from urls: { "mypy": "https://invalid.com", } If you would like to skip downloading metadata for these packages please add 'simpleapi_skip=["mypy"]' to your 'pip.parse' call. ```
… follow convention (#3128) Prefix `experimental_allow_relative_imports` with `python_` to match the rest of the directives. 1.6.0 hasn't been released yet, so this is a non-breaking change.
I noticed that the CI error messages for #3114 are not useful. This patch aims to help with that by printing the output of the REPL code. If there's an exception during startup for example, then the test log will now contain the stack trace. --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )