[pull] main from bazel-contrib:main#430
Merged
Merged
Conversation
Add starlark flags for `--python_path`, `--build_python_zip` and `--incompatible_default_to_explicit_init_py`. - The transitions logic is updated to set both the native and starlark versions of the flags to allow alternating between them until the native ones are removed. - `--build_python_zip` is changed to `boolean` instead of `Tristate` with default value set to `True` on `windows` and `False` otherwise. - `scope = universal` attribute is added to the starlark flags so they can be propagated to exec config on Bazel 9. This required upgrading `bazel_skylib` version to have `scope` attribute defined. Work towards: #3252 cc @gregestren --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Richard Levasseur <rlevasseur@google.com>
I was playing around with the [multi-platform PyPI example](https://rules-python.readthedocs.io/en/latest/howto/multi-platform-pypi-deps.html) and noticed that the `pip.default` arguments were wrong. Co-authored-by: Richard Levasseur <richardlev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )