[pull] main from bazel-contrib:main#543
Merged
pull[bot] merged 2 commits intogarymm:mainfrom Mar 8, 2026
Merged
Conversation
…#3653) The compression level isn't being correctly passed by the zipapp rule to the zipper program, resulting in an error if custom compression is specified. To fix, pass the arg correctly to the zipper. `venv_zipapp_test.py` is updated to also confirm zipapps are properly compressed when configured in the BUILD target. Fixes #3646
Currently, the toolchain only sets the make variables if it's an in-build toolchain. This breaks for platform toolchains. To fix, check for platform toolchains and set the make vars appropriately. This helps fix the BCR rules for `@glib`, which recently added a requirement that the Make variable `$(PYTHON3)` must always be defined by the current Python toolchain. Co-authored-by: Richard Levasseur <richardlev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )