Skip to content

Allow differentiating blob stores by buckets#378

Merged
gaul merged 1 commit intogaul:masterfrom
timuralp:feature/bucket-locator-glob
Oct 20, 2021
Merged

Allow differentiating blob stores by buckets#378
gaul merged 1 commit intogaul:masterfrom
timuralp:feature/bucket-locator-glob

Conversation

@timuralp
Copy link
Copy Markdown
Collaborator

Allows differentiating the backend blob stores by configured buckets.
The commit allows using the same s3proxy credentials across the
different backends and relies on the bucket names to disambiguate them.

If no buckets are configured, the prior blob store selection algorithm
is used, which returns the first configured blob store for the specified
identity.

The patch supports the glob syntax, which allows specifying groups of
buckets more easily. However, there is no checking for overlapping
globs.

Fixes: #371

Allows differentiating the backend blob stores by configured buckets.
The commit allows using the same s3proxy credentials across the
different backends and relies on the bucket names to disambiguate them.

If no buckets are configured, the prior blob store selection algorithm
is used, which returns the first configured blob store for the specified
identity.

The patch supports the glob syntax, which allows specifying groups of
buckets more easily. However, there is no checking for overlapping
globs.

Fixes: gaul#371
@timuralp
Copy link
Copy Markdown
Collaborator Author

This PR conflicts with #376 and only one of these should be merged. The difference is that this PR implements glob support, whereas #376 only matched on exact bucket names.

@gaul gaul merged commit 558efb7 into gaul:master Oct 20, 2021
@gaul
Copy link
Copy Markdown
Owner

gaul commented Oct 20, 2021

Thank you for your contribution @timuralp! Could you add some documentation here:

https://github.com/gaul/s3proxy#middlewares

Also fix the typo "alisting" -> "aliasing".

@timuralp timuralp deleted the feature/bucket-locator-glob branch October 23, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use container names to disambiguate backend stores

2 participants