code clean up

Author: gboeing

notebooks/00-osmnx-features-demo.ipynb

@@ -90,7 +90,7 @@
    "outputs": [],
    "source": [
     "# get a fully bidirection network (as a MultiDiGraph)\n",
-    "ox.settings.bidirectional_network_types += \"drive\"\n",
+    "ox.settings.bidirectional_network_types.append(\"drive\")\n",
     "G = ox.graph.graph_from_place(\"Piedmont, California, USA\", network_type=\"drive\")\n",
     "\n",
     "# convert your MultiDiGraph to an undirected MultiGraph\n",

notebooks/03-graph-place-queries.ipynb

@@ -47,8 +47,8 @@
     "  - `drive_service` - get drivable streets, including service roads\n",
     "  - `walk` - get all streets and paths that pedestrians can use (this network type ignores one-way directionality)\n",
     "  - `bike` - get all streets and paths that cyclists can use\n",
-    "  - `all` - download all non-private OSM streets and paths\n",
-    "  - `all_private` - download all OSM streets and paths, including private-access ones\n",
+    "  - `all` - download all OSM streets and paths, including private-access ones\n",
+    "  - `all_public` - download all non-private OSM streets and paths\n",
     "\n",
     "Or you can define your own fine-tuned network type using OSMnx's `custom_filter` parameter (to get just highways, or railways, canals, etc).\n",
     "\n",

notebooks/08-custom-filters-infrastructure.ipynb

@@ -145,7 +145,6 @@
     "\n",
     "# union: get all ways with either a 'cycleway:right' or 'cycleway:left' tag\n",
     "cf = [cf1, cf2]\n",
-    "ox.settings.useful_tags_way.extend([cf1, cf2])\n",
     "G = ox.graph.graph_from_place(place, custom_filter=cf, retain_all=True)\n",
     "print(len(G))"
    ]

notebooks/14-osmnx-to-igraph.ipynb

@@ -187,7 +187,7 @@
    "outputs": [],
    "source": [
     "%%time\n",
-    "closeness2 = nx.closeness_centrality(G_nx, distance=weight, wf_improved=True)\n",
+    "closeness2 = nx.closeness_centrality(G_nx.to_undirected(), distance=weight, wf_improved=True)\n",
     "max_closeness2 = max(closeness2.items(), key=operator.itemgetter(1))[0]"
    ]
   },

notebooks/16-download-osm-geospatial-features.ipynb

@@ -149,7 +149,7 @@
     "useful_tags = [\"access\", \"parking\", \"surface\", \"capacity\", \"fee\"]\n",
     "for node, feature in zip(nn, features[useful_tags].to_dict(orient=\"records\"), strict=False):\n",
     "    feature = {k: v for k, v in feature.items() if pd.notna(v)}\n",
-    "    G.nodes[node].update({\"parking\": feature})"
+    "    G.nodes[node].setdefault(\"parking\", []).append(feature)"
    ]
   },
   {

notebooks/17-street-network-orientations.ipynb

@@ -98,7 +98,7 @@
     "    print(ox.utils.ts(), place)\n",
     "\n",
     "    # get undirected graphs with edge bearing attributes\n",
-    "    G = ox.graph.graph_from_place(place, network_type=\"drive\")\n",
+    "    G = ox.graph.graph_from_place(places[place], network_type=\"drive\")\n",
     "    Gu = ox.bearing.add_edge_bearings(ox.convert.to_undirected(G))\n",
     "    fig, ax = ox.plot.plot_orientation(Gu, ax=ax, title=place, area=True)\n",
     "\n",