Skip to content

Commit a44fc20

Browse files
J8k3claude
andcommitted
Fix lint: comma-spacing in Payment.mjs test; document full lint command
eslint:tests catches Payment.mjs too — document that npx grunt eslint runs all five targets, not just eslint:core. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 8e0c192 commit a44fc20

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

AGENTS.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@
88
- Node 24
99
- `npm ci`
1010
- `npm test`
11+
- **Before committing any JS/MJS change, run the full lint suite in Docker:**
12+
```
13+
npx grunt eslint
14+
```
15+
This runs all five targets: `eslint:configs`, `eslint:core`, `eslint:web`, `eslint:node`, `eslint:tests`. Running only `eslint:core` misses errors in test files and other targets. Do not push without a clean lint run.
1116
- Dev server with auto-rebuild: `npm start` (port 8080). Production build: `npm run build` (output in `build/prod/`). If the production build OOMs, set `NODE_OPTIONS=--max_old_space_size=2048`.
1217
- **Do not run `npm run build` or `npm start` on Windows.** The local Node version is not guaranteed to match CI and webpack builds will silently fail or produce wrong output. Build verification belongs in Docker/Linux CI only.
1318
- Do not spend time fixing Windows-only runtime or dependency issues unless explicitly requested.
@@ -34,6 +39,7 @@ Follow `CONTRIBUTING.md` coding conventions: 4-space indentation, CamelCase clas
3439
- Split work before committing when a reviewer would benefit from evaluating the pieces independently.
3540
- Only keep changes together when separating them would make the behavior harder to understand, test, or revert.
3641
- Prefer squash or amend for related consecutive changes — if a follow-up commit only fixes or extends the immediately preceding commit, squash them into one rather than leaving a trail of iterative noise in the log.
42+
- When CI flags a lint or test failure after a push, fix it locally and **amend or squash into the failing commit** (using `git push --force-with-lease`) rather than adding a new fix commit on top. A chain of "Fix lint" commits is the failure mode this rule prevents.
3743

3844
## APC Cross-Reference (Standing Instruction)
3945

tests/operations/tests/Payment.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1560,7 +1560,7 @@ TestRegister.addTests([
15601560
expectedOutput: JSON.stringify([
15611561
{ tag: "9F26", name: "Application Cryptogram (ARQC/TC/AAC)", constructed: false, class: "Application", source: "ICC", format: "b", length: 8, valueHex: "A1B2C3D4E5F60708" },
15621562
{ tag: "9F27", name: "Cryptogram Information Data (CID)", constructed: false, class: "Application", source: "ICC", format: "b", length: 1, valueHex: "80" },
1563-
{ tag: "9F36", name: "Application Transaction Counter (ATC)",constructed: false, class: "Application", source: "ICC", format: "b", length: 2, valueHex: "0001" },
1563+
{ tag: "9F36", name: "Application Transaction Counter (ATC)", constructed: false, class: "Application", source: "ICC", format: "b", length: 2, valueHex: "0001" },
15641564
], null, 4),
15651565
recipeConfig: [{ op: "Parse EMV TLV", args: [false] }]
15661566
},

0 commit comments

Comments
 (0)