fix: From Base operation produces wrong results for fractional inputs#2285
Merged
Conversation
The fractional part loop used native `+=` and `Math.pow()` with BigNumber objects, causing string concatenation instead of arithmetic addition. Replace with BigNumber `.plus()` and `.pow()` methods. Closes gchq#2240 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
williballenthin
force-pushed
the
fix-2240
branch
from
db042bc to
7f10edc
Compare
GCHQDeveloper581
approved these changes
Jun 20, 2026
GCHQDeveloper581
left a comment
GCHQDeveloper581
left a comment
Contributor
There was a problem hiding this comment.
Looks good!
Thank you for your contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2240
AI disclosure
Claude Code Opus 4.6