Fix Uint8Array concat crash in Parse IPv4 header#2409
Open
Zish19 wants to merge 1 commit into
Open
Conversation
e827a28 to
1c5fafd
Compare
Author
|
CLA issue has been resolved and the branch has been updated successfully. |
GCHQDeveloper581
requested changes
May 20, 2026
Contributor
GCHQDeveloper581
left a comment
There was a problem hiding this comment.
Please add a test that would fail without this patch and pass with it present.
Please also provide an AI disclosure in the header of your PR stating if AI has been used in creation of the PR and if so what model(s) has(have) been used.
Author
|
Thanks for the review. I’ll add a regression test covering the malformed/raw input case that previously triggered the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2400
Summary
Fixes a runtime TypeError in the
Parse IPv4 headeroperation caused by calling.concat()on aUint8Array.Root Cause
input.slice()returns aUint8Array, not a standard JavaScriptArray.The operation previously attempted to do:
Since
Uint8Arraydoes not implement.concat(), malformed/raw input caused:This affects both:
fromHex()also returnsUint8Array)Fix
Replaced the unsafe concatenation with array spreading:
This preserves the exact byte sequence while producing a standard array compatible with the downstream checksum logic.
Notes