Ensure theme switches to preferred colour scheme on first load#2520
Open
JakeYallop wants to merge 1 commit into
Open
Ensure theme switches to preferred colour scheme on first load#2520JakeYallop wants to merge 1 commit into
JakeYallop wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently opening the page for the first time does not correctly apply the users preferred colour scheme.
In
OptionsWaiter, we do this to apply the theme:CyberChef/src/web/waiters/OptionsWaiter.mjs
Lines 177 to 184 in d735496
However,
themeFromStorageis already set to "classic" at this point, assigned here:CyberChef/src/web/App.mjs
Line 36 in d735496
The fix is set the default theme to
undefinedand let it be set from either localStorage orgetPreferredColorScheme().Related issues: #1921, #1901
AI disclosure
No AI was used in the creation of this pull request.