Added Content-Security-Policy.#2564
Open
Fra3zz wants to merge 1 commit into
Open
Conversation
Member
|
@Fra3zz thank you for creating this merge request - a Content Security Policy is a key priority for this project. However, as it is, I think this pull request contains a number of changes which could be split out into smaller pull requests before we tackle the Content Security Policy (e.g. removing inline CSS, removing inline JavaScript...). That would help us reviewers and increase our confidence in each change. |
|
yes a CSP will mitigate and reduce xss vulns, even happens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Content-Security-Policy implemented to improve security against XSS attacks. All but one src utilizes "self", excluding inline styles. Inline scripts were placed into their own respective files in /src/web/index_assets.
Existing Issue
Partially fixes the issue #1486. Was unable to implement secure CSP for inline style.
Screenshots
No visual changes.
AI disclosure
No AI was utilized.
Test Coverage
No testing necessary. Console dose not produce any new errors.