Use HTTPS for AccurateRip database lookups - #402
Open
LynxTWO wants to merge 1 commit into
Open
Conversation
LynxTWO
marked this pull request as ready for review
July 31, 2026 18:38
Author
|
@c72578, this small compatibility update is ready for review when you have a chance. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DriveOffsets.binWhy
Both payloads were downloaded over HTTP. The payloads are not independently
signed, so an on-path modification could change verification data or drive
offset data before CUETools caches and consumes it. AccurateRip currently serves
both routes over HTTPS.
This patch changes only the scheme. URL paths, request methods, proxy behavior,
request throttling, cache behavior, parsing, and existing failure handling stay
unchanged.
Validation
dotnet build CUETools.AccurateRip/CUETools.AccurateRip.csproj -c Releasebuilds net20, net47, and netstandard2.0 with zero warnings and zero errors
DriveOffsets.binreturned HTTP 200 over HTTPS with a valid TLS chain on2026-07-31
expected HTTP 404 on 2026-07-31
CUETools.AccurateRipcontain zero cleartext AccurateRipruntime URLs and two HTTPS runtime URLs