Skip to content

Use HTTPS for AccurateRip database lookups - #402

Open
LynxTWO wants to merge 1 commit into
gchudov:masterfrom
LynxTWO:agent/upstream-accuraterip-https
Open

Use HTTPS for AccurateRip database lookups#402
LynxTWO wants to merge 1 commit into
gchudov:masterfrom
LynxTWO:agent/upstream-accuraterip-https

Conversation

@LynxTWO

@LynxTWO LynxTWO commented Jul 31, 2026

Copy link
Copy Markdown

Summary

  • use HTTPS for AccurateRip dBAR database lookups
  • use HTTPS when refreshing DriveOffsets.bin
  • do not fall back to cleartext HTTP

Why

Both payloads were downloaded over HTTP. The payloads are not independently
signed, so an on-path modification could change verification data or drive
offset data before CUETools caches and consumes it. AccurateRip currently serves
both routes over HTTPS.

This patch changes only the scheme. URL paths, request methods, proxy behavior,
request throttling, cache behavior, parsing, and existing failure handling stay
unchanged.

Validation

  • dotnet build CUETools.AccurateRip/CUETools.AccurateRip.csproj -c Release
    builds net20, net47, and netstandard2.0 with zero warnings and zero errors
  • DriveOffsets.bin returned HTTP 200 over HTTPS with a valid TLS chain on
    2026-07-31
  • a deliberately nonexistent dBAR URL reached the HTTPS route and returned the
    expected HTTP 404 on 2026-07-31
  • the three C# files in CUETools.AccurateRip contain zero cleartext AccurateRip
    runtime URLs and two HTTPS runtime URLs

@LynxTWO
LynxTWO marked this pull request as ready for review July 31, 2026 18:38
@LynxTWO

LynxTWO commented Jul 31, 2026

Copy link
Copy Markdown
Author

@c72578, this small compatibility update is ready for review when you have a chance. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant