Tighten candidate budget accounting

Author: gcomneno

iss/strategies/balanced_root_scale.py

@@ -34,16 +34,16 @@ def search(self, n: int, budget: SearchBudget) -> SearchAttempt:
         prime_checks = 0
 
         for p in local_prime_candidates(center, budget.radius):
-            candidates_tested += 1
-            prime_checks += 1
-
-            if candidates_tested > budget.max_candidates:
+            if candidates_tested >= budget.max_candidates:
                 return self._budget_exhausted(
                     budget=budget,
                     candidates_tested=candidates_tested,
                     prime_checks=prime_checks,
                 )
 
+            candidates_tested += 1
+            prime_checks += 1
+
             if n % p != 0:
                 continue
 

iss/strategies/log_scale_semiprime.py

@@ -40,16 +40,16 @@ def search(self, n: int, budget: SearchBudget) -> SearchAttempt:
             center = integer_nth_root_floor(n, denominator)
 
             for p in local_prime_candidates(center, budget.radius):
-                candidates_tested += 1
-                prime_checks += 1
-
-                if candidates_tested > budget.max_candidates:
+                if candidates_tested >= budget.max_candidates:
                     return self._budget_exhausted(
                         budget=budget,
                         candidates_tested=candidates_tested,
                         prime_checks=prime_checks,
                     )
 
+                candidates_tested += 1
+                prime_checks += 1
+
                 if n % p != 0:
                     continue
 

tests/test_balanced_root_scale.py

@@ -51,6 +51,7 @@ def test_balanced_root_scale_respects_candidate_budget() -> None:
     assert result.status == "no_match"
     assert result.attempts[0].status == "budget_exhausted"
     assert result.attempts[0].reason == "max_candidates_exceeded"
+    assert result.attempts[0].bounds.candidates_tested == 0
 
 
 def test_balanced_root_scale_payload_is_structural_dataclass() -> None:

tests/test_log_scale_semiprime.py

@@ -53,6 +53,7 @@ def test_log_scale_semiprime_respects_candidate_budget() -> None:
     assert result.status == "no_match"
     assert result.attempts[0].status == "budget_exhausted"
     assert result.attempts[0].reason == "max_candidates_exceeded"
+    assert result.attempts[0].bounds.candidates_tested == 1
 
 
 def test_log_scale_semiprime_returns_structural_payload_dataclass() -> None: