Skip to content

Commit ef9132f

Browse files
committed
query by value to allow signed/unsigned conversion (N64Recomp#148)
1 parent a8a9455 commit ef9132f

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

librecomp/src/mod_manifest.cpp

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -451,22 +451,20 @@ recomp::mods::ModOpenError parse_manifest_config_schema_option(const nlohmann::j
451451

452452
auto precision = config_schema_json.find(config_schema_precision_key);
453453
if (precision != config_schema_json.end()) {
454-
int64_t precision_int64;
455-
if (get_to<int64_t>(*precision, precision_int64)) {
456-
option_number.precision = precision_int64;
457-
}
458-
else {
454+
if (!precision->is_number()) {
459455
error_param = config_schema_precision_key;
460456
return recomp::mods::ModOpenError::IncorrectConfigSchemaType;
461457
}
458+
option_number.precision = precision->template get<int64_t>();
462459
}
463460

464461
auto percent = config_schema_json.find(config_schema_percent_key);
465462
if (percent != config_schema_json.end()) {
466-
if (!get_to<bool>(*percent, option_number.percent)) {
463+
if (!percent->is_boolean()) {
467464
error_param = config_schema_percent_key;
468465
return recomp::mods::ModOpenError::IncorrectConfigSchemaType;
469466
}
467+
option_number.percent = percent->template get<bool>();
470468
}
471469

472470
auto default_value = config_schema_json.find(config_schema_default_key);

0 commit comments

Comments
 (0)