Skip to content

Commit 378366b

Browse files
authored
[6034518] Remove return statement preventing remote auto tuning (NVIDIA#1361)
### What does this PR do? Remove return statement from the code checking remote auto tuning config arguments since that results in skipping adding the actual remote tuning config to the trtexec cmd. **Root cause**: The necessary flags do not get added to `self._base_cmd.extend(trtexec_args)` when remote autotuning is enabled. **Before fix**: ``` ['trtexec', '--avgRuns=100', '--iterations=100', '--warmUp=50', '--stronglyTyped', \ '--saveEngine=engine.trt', '--timingCacheFile=trtexec_timing.cache', \ '--onnx=baseline.onnx'] ``` **After fix**: ``` ['trtexec', '--avgRuns=100', '--iterations=100', '--warmUp=50', '--stronglyTyped', \ '--saveEngine=engine.trt', '--timingCacheFile=trtexec_timing.cache', \ '--remoteAutoTuningConfig=$CONFIG', '--safe', '--skipInference', \ '--onnx=baseline.onnx'] ``` Notice that the remote autotuning and related flags are now included in the `trtexec` command. **Related PR**: NVIDIA#1259 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Bug Fixes * Fixed an issue where remote autotuning configuration arguments were not being properly included in benchmark commands, ensuring all remote autotuning settings are now correctly applied during execution. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: dmoodie <dmoodie@nvidia.com>
1 parent a492fa9 commit 378366b

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

modelopt/onnx/quantization/autotune/benchmark.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,6 @@ def __init__(
220220
"Remote autotuning requires '--skipInference' to be set. Adding it to trtexec arguments."
221221
)
222222
self.trtexec_args.append("--skipInference")
223-
return
224223
except ImportError:
225224
self.logger.warning(
226225
"Remote autotuning is not supported with TensorRT version < 10.15. "

0 commit comments

Comments
 (0)