Several ways to draw transistors

Draws transistors in several ways: 0:Active, 1:Single-Flip, 2:Sticky and 3:All
Single-Flip highlights transistors that have changed state only once
Sticky highlights transistors that have changed state one or more times
The option key that cycles the mode is "."
The baseline gets tagged with the "T" key to turn transistor view on or off

Author: gdevic

src/ClassVisual.cpp

@@ -26,6 +26,35 @@
 #define VIA_POLY   (1 << VIA_POLY_SHIFT)
 #define TRANSISTOR (1 << TRANSISTOR_SHIFT)
 
+ClassVisual::ClassVisual()
+{
+    connect(&::controller, &ClassController::onRunStopped, this, &ClassVisual::onRunStopped);
+}
+
+void ClassVisual::onRunStopped()
+{
+    // Count the number of times each transistor has changed its state from the base (initial) state
+    for (uint i = 0; i < MAX_TRANS; i++)
+    {
+        bool state = ::controller.getNetlist().isTransOn(i);
+        bool oldState = (uchar(m_transBaseState[i]) ^ m_transFlipCount[i]) & 1;
+        if (state != oldState)
+            m_transFlipCount[i] = (m_transFlipCount[i] + 1) & 0x7F; // Prevents the overflow
+    }
+}
+
+/*
+ * Single-Flip and Sticky transistor view modes use base state, an array containing each transistor on/off state at the time of
+ * the start of a test, and another array that counts the number of transitions each time a run stops.
+ */
+void ClassVisual::armTransFlipCount()
+{
+    memset(m_transFlipCount, 0, sizeof(m_transFlipCount));
+    for (uint i = 0; i < MAX_TRANS; i++)
+        m_transBaseState[i] = ::controller.getNetlist().isTransOn(i);
+    qInfo() << "Transistor flip counter reset";
+}
+
 /*
  * Attempts to load and generate all chip resource that we expect to have
  */
@@ -1283,10 +1312,10 @@ void ClassVisual::experimental_2()
 }
 
 /*
- * Draws all transistors in two shades: yellow for active and gray for inactive
- * with an additional option to highlight all of them irrespective of their state
+ * Draws transistors in several ways: 0:Active, 1:Single-Flip, 2:Sticky and 3:All
+ * The base colors that are used are yellow for active and gray for inactive transistors.
  */
-void ClassVisual::expDrawTransistors(QPainter &painter, const QRect &viewport, bool highlightAll)
+void ClassVisual::drawTransistors(QPainter &painter, const QRect &viewport, uint mode)
 {
     const static QBrush brush[2] = { Qt::gray, Qt::yellow };
     const static QPen pens[2] = { QPen(QColor(), 0, Qt::NoPen), QPen(QColor(255, 0, 255), 1, Qt::SolidLine) };
@@ -1296,9 +1325,15 @@ void ClassVisual::expDrawTransistors(QPainter &painter, const QRect &viewport, b
         // Speed up rendering by clipping to the viewport's image rectangle
         if (t.box.intersected(viewport) != QRect())
         {
-            bool state = ::controller.getSimZ80().getNetState(t.gatenet);
+            bool state = true;  // "All" (default)
+            if (mode == 0)      // "Active"
+                state = ::controller.getSimZ80().getNetState(t.gatenet);
+            else if (mode == 1) // "Single-Flip"
+                state = m_transFlipCount[t.id] == 1;
+            else if (mode == 2) // "Sticky"
+                state = m_transFlipCount[t.id];
             painter.setPen(pens[state]);
-            painter.setBrush(brush[state || highlightAll]);
+            painter.setBrush(brush[state]);
             painter.drawPath(t.path);
         }
     }

src/ClassVisual.h

@@ -41,7 +41,7 @@ class ClassVisual: public QObject
     Q_OBJECT
 
 public:
-    ClassVisual() {};
+    explicit ClassVisual();
 
     bool loadChipResources(QString dir);// Attempts to load all expected chip resources
     QImage &getImage(uint img);         // Returns a reference to the image by the image index
@@ -58,24 +58,30 @@ class ClassVisual: public QObject
     QString getFeaturesAt(int x, int y);  // Returns the list of features at the specified image coordinates
     bool isLatch(net_t net);              // Returns true if a net is part of any latch
     void getLatch(net_t net, tran_t &t1, tran_t &t2, net_t &n1, net_t &n2); // Returns latch transistors and nets
-
-public slots:
     void detectLatches();               // Detects latches and also loads custom latch definitions
     void drawLatches(QPainter &painter, const QRect &viewport);
+    void drawTransistors(QPainter &painter, const QRect &viewport, uint mode);
+    void armTransFlipCount();
+
+public slots:
     void experimental(int n);           // Runs experimental function number n
-    void expDrawTransistors(QPainter &painter, const QRect &viewport, bool highlightAll);
     void expDynamicallyNameNets(QPainter &painter, const QRect &viewport, qreal scale); // Maps nearby net names
 
+private slots:
+    void onRunStopped();
+
 private:
     QVector<transvdef> m_transvdefs;    // Array of transistor visual definitions
+    bool m_transBaseState[MAX_TRANS];   // Base state of each transistor
+    uchar m_transFlipCount[MAX_TRANS];  // Number of times each transistor changed its state
     QHash<net_t, segvdef> m_segvdefs;   // Hash of segment visual definitions, key is the segment net number
     QHash<net_t, segvdef> m_segvdefs2;  // Alternate segment visual definitions
     bool use_alt_segdef {false};        // Use alternate segment definitions
     QVector<latchdef> m_latches;        // Array of latches
     QVector<QImage> m_img;              // Chip layer images
     uint m_sx {};                       // X size of all images and maps
     uint m_sy {};                       // Y size of all images and maps
-    uint m_mapsize;                     // Map size in bytes, equals to (m_sx * m_sy)
+    uint m_mapsize {};                  // Map size in bytes, equals to (m_sx * m_sy)
     uint16_t *m_p3[3] {};               // Layer map: [0] diffusion, [1] poly, [2] metal
     uchar *m_fmap {};                   // Feature bitmap
 

src/WidgetImageView.cpp

@@ -43,7 +43,7 @@ WidgetImageView::~WidgetImageView()
     QSettings settings;
     settings.setValue("imageViewDrawActiveNets-" + whatsThis(), m_drawActiveNets);
     settings.setValue("imageViewDrawAnnotations-" + whatsThis(), m_drawAnnotations);
-    settings.setValue("imageViewDrawActiveTransistors-" + whatsThis(), m_drawActiveTransistors);
+    settings.setValue("imageViewDrawTransistors-" + whatsThis(), m_drawTransistors);
     settings.setValue("imageViewDrawLatches-" + whatsThis(), m_drawLatches);
 
     QString layers = m_ov->getLayers();
@@ -66,12 +66,12 @@ void WidgetImageView::init(QString sid)
     QSettings settings;
     m_drawActiveNets = settings.value("imageViewDrawActiveNets-" + whatsThis(), false).toBool();
     m_drawAnnotations = settings.value("imageViewDrawAnnotations-" + whatsThis(), true).toBool();
-    m_drawActiveTransistors = settings.value("imageViewDrawActiveTransistors-" + whatsThis(), true).toBool();
+    m_drawTransistors = settings.value("imageViewDrawTransistors-" + whatsThis(), true).toBool();
     m_drawLatches = settings.value("imageViewDrawLatches-" + whatsThis(), false).toBool();
 
     m_ov->setButton(0, m_drawActiveNets);
     m_ov->setButton(1, m_drawAnnotations);
-    m_ov->setButton(2, m_drawActiveTransistors);
+    m_ov->setButton(2, m_drawTransistors);
     m_ov->setButton(3, m_drawLatches);
 
     m_ov->createImageButtons(::controller.getChip().getImageNames());
@@ -333,10 +333,10 @@ void WidgetImageView::paintEvent(QPaintEvent *)
     //------------------------------------------------------------------------
     // Draw transistors
     //------------------------------------------------------------------------
-    if ((m_drawActiveTransistors || m_drawAllTransistors) && mouseOff)
+    if (m_drawTransistors && mouseOff)
     {
         painter.save();
-        ::controller.getChip().expDrawTransistors(painter, viewportTex, m_drawAllTransistors);
+        ::controller.getChip().drawTransistors(painter, viewportTex, m_drawTransistorMode);
         painter.restore();
     }
     //------------------------------------------------------------------------
@@ -721,12 +721,18 @@ void WidgetImageView::keyPressEvent(QKeyEvent *event)
         m_ov->setButton(1, m_drawAnnotations);
         break;
     case Qt::Key_T:
-        m_drawActiveTransistors = !m_drawActiveTransistors;
-        m_drawAllTransistors = false;
-        m_ov->setButton(2, m_drawActiveTransistors);
+        m_drawTransistors = !m_drawTransistors;
+        m_ov->setButton(2, m_drawTransistors);
+        if (m_drawTransistors) ::controller.getChip().armTransFlipCount();
         break;
     case Qt::Key_Period:
-        m_drawAllTransistors = !m_drawAllTransistors; break;
+        if (m_drawTransistors)
+        {
+            if (++m_drawTransistorMode == 4) // 0:Active, 1:Single-Flip, 2:Sticky and 3:All
+                m_drawTransistorMode = 0;
+            static const QStringList modes = {"Active", "Single-Flip", "Sticky", "All"};
+            qInfo() << "Draw transistor mode:" << modes[m_drawTransistorMode];
+        }
         break;
     case Qt::Key_L:
         m_drawLatches = !m_drawLatches;

src/WidgetImageView.h

@@ -91,10 +91,10 @@ private slots:
     const QRect *m_highlight_trans {};  // Transistor bounding rectangle to highlight in the current image
     QRect m_r;                          // Rectangle used by the show() scripting command to highlight a rectangle
     bool m_drawActiveNets;              // Draw active nets
-    uint m_drawActiveNetsOrder {0};     // The order of drawing active nets bit[0], auto toggle bit[1]
+    uint m_drawActiveNetsOrder {};      // The order of drawing active nets bit[0], auto toggle bit[1]
     bool m_drawAnnotations;             // Draw image annotations
-    bool m_drawActiveTransistors;       // Draw currently active transistors
-    bool m_drawAllTransistors {false};  // Draw all transistors (irrespective of their state)
+    bool m_drawTransistors;             // Draw transistors
+    uint m_drawTransistorMode {};       // Draw transistors mode
     bool m_drawLatches;                 // Draw latches
     bool m_drawNetNames {true};         // Dynamically write nearby net names (experimental)
     QString m_dropppedFile;             // File name of the file being dropped by a drag-and-drop operation