Skip to content

Fix tidy3d holes#566

Merged
joamatab merged 3 commits intomainfrom
fix-tidy3d-holes
Apr 12, 2025
Merged

Fix tidy3d holes#566
joamatab merged 3 commits intomainfrom
fix-tidy3d-holes

Conversation

@tvt173
Copy link
Copy Markdown
Collaborator

@tvt173 tvt173 commented Apr 11, 2025

properly removes holes from shapely shapes, such as rings

image

fixes #565

Summary by Sourcery

Improve handling of geometric shapes in Tidy3D component by removing holes and simplifying geometry processing

Bug Fixes:

  • Fixed issue with polygon processing by using buffer method to remove holes and simplify shapes

Enhancements:

  • Refactored polyslabs generation to use more robust geometry conversion
  • Simplified plotting and geometry intersection logic

Chores:

  • Removed redundant get_vertices method from base component class

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Apr 11, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@tvt173 tvt173 requested a review from joamatab April 11, 2025 23:53
@github-actions github-actions Bot added the bug Something isn't working label Apr 11, 2025
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@joamatab joamatab merged commit e8afbc8 into main Apr 12, 2025
9 of 18 checks passed
@joamatab joamatab deleted the fix-tidy3d-holes branch April 12, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ring resonator with plugging tidy3D gdsfactory

2 participants