Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add microwave-to-optical quantum transducer components and models #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Add microwave-to-optical quantum transducer components and models #413
Changes from all commits
35361df6b5502ecb84ae6File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
layer_metalis accepted as an argument but not used anywhere in this cell (the capacitor/inductor and feedlines take their layers from their own implementations/cross-sections). Either remove this parameter or plumb it through by allowing the subcomponents/cross_section to be configured so callers can actually control the metal layer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inductor is placed but never electrically connected to the capacitor, so the intended parallel LC resonator is not actually formed (the generated netlist has no nets involving
meander_inductor). Connect the inductor ports to the capacitor pads (or add explicit interconnect geometry) so the LC is electrically in parallel as described.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring describes “two large interdigitated metal pads”, but the implementation uses two plain rectangles separated by a gap. Update the docstring to match the actual geometry, or implement an interdigitated electrode structure if that’s what’s intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feedline straights are only moved next to the pads but never connected to the pad ports, so circuit connectivity is missing (the generated netlist shows no nets connecting the straights to the rectangles). Use
connect(...)(or routing) to attach the feedlines to specific pad ports so the component netlist correctly represents electrical connections.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.