add qpdk--sample-projects#574
Open
thanojo wants to merge 3 commits into
Open
Conversation
thanojo
requested review from
Alex-l-r,
ThomasPluck,
joamatab and
nikosavola
as code owners
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the Quantum RF PDK (qpdk), a comprehensive library for superconducting quantum circuit design and simulation. It includes a wide range of parameterized layout cells, such as transmons, resonators, and airbridges, supported by frequency-dependent S-parameter models built using JAX and SAX. The PR also adds simulation utilities for Ansys AEDT, sample scripts, and a robust testing suite for the analytical models. I have no feedback to provide.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Member
|
I'm a bit confused, should this sample project be generated instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds sample projects from
gfp-sample-projectsintoqpdk--sample-projects/.