Skip to content

Update doroutes to ~=0.6.0#586

Merged
nikosavola merged 3 commits into
mainfrom
remove-doroutes
May 12, 2026
Merged

Update doroutes to ~=0.6.0#586
nikosavola merged 3 commits into
mainfrom
remove-doroutes

Conversation

@joamatab
Copy link
Copy Markdown
Contributor

@joamatab joamatab commented May 11, 2026

Summary

  • Update doroutes dependency from >=0.2.0 to ~=0.6.0

Test plan

  • Verify the project installs correctly with doroutes~=0.6.0

@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label May 11, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'doroutes' dependency from the pyproject.toml file. I have no feedback to provide.

@nikosavola
Copy link
Copy Markdown
Member

@copilot Could you fix the errors in CI happening for this PR? Make sure you can run the tests and pre-commit hooks successfully.

Copy link
Copy Markdown
Contributor

Copilot AI commented May 11, 2026

@copilot Could you fix the errors in CI happening for this PR? Make sure you can run the tests and pre-commit hooks successfully.

Fixed in 5e07b0a. The CI failures were caused by removing doroutes from pyproject.toml without also removing its import and usage in qpdk/tech.py. I removed the from doroutes.bundles import add_bundle_astar import, the route_astar/route_astar_cpw routing strategy definitions that depended on it, and their entries in routing_strategies. Also updated AGENTS.md. All pre-commit hooks and 860 tests pass.

@github-actions github-actions Bot added documentation Improvements or additions to documentation python Pull requests that update python code pdk PDK issue technology Relating to tech files labels May 11, 2026
@joamatab joamatab changed the title Remove doroutes from dependencies Update doroutes to ~=0.6.0 May 11, 2026
@github-actions github-actions Bot removed documentation Improvements or additions to documentation python Pull requests that update python code pdk PDK issue technology Relating to tech files labels May 11, 2026
@nikosavola
Copy link
Copy Markdown
Member

Was this PR supposed to update or remove doroutes ? It was trying to remove it before.

Co-Authored-By: Claude <noreply@anthropic.com>
@nikosavola nikosavola enabled auto-merge May 12, 2026 15:29
@nikosavola nikosavola added this pull request to the merge queue May 12, 2026
Merged via the queue into main with commit 37b3081 May 12, 2026
28 checks passed
@nikosavola nikosavola deleted the remove-doroutes branch May 12, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants