feat(accessibility): comprehensive keyboard navigation support (#396)#417
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #417 +/- ##
=======================================
Coverage 64.68% 64.68%
=======================================
Files 47 47
Lines 2308 2308
Branches 597 597
=======================================
Hits 1493 1493
Misses 698 698
Partials 117 117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…teractive elements
Implements keyboard accessibility improvements across the entire application to resolve issue #396 and improve overall accessibility. ## Changes ### SearchableSelect Component - Migrated from Popover to Radix Vue Combobox for built-in keyboard support - Full ArrowUp/Down/Enter/Escape navigation - Restored selected-prepend slot for toolbar icons - Made 'Create new' option keyboard accessible as ComboboxItem - Fixed case-insensitive matching for duplicate detection ### Interactive Elements - Added tabindex, role='button', @keydown.enter, @keydown.space to: - Connection cards (connect-list.vue) - File items (file-list.vue) - Navigation icons (the-aside.vue) - Toolbar favorites (tool-bar.vue) - Breadcrumb items (path-breadcrumb.vue) - Node cards (node-state.vue) - Cluster/template table headers (cluster-state.vue) ### Form Submission - Added @submit.prevent to 8 modal dialog forms - Fixed double-submit regression by removing redundant @click handlers - Enter key now submits forms correctly ### Confirmation Dialogs - Scoped Enter key to confirm buttons only (not entire dialog) - Prevents accidental destructive actions ### Context Menus - Added role='menu' and role='menuitem' attributes - Implemented focus management (first item focused on open) - Added Shift+F10 keyboard opener for editor context menus - Added Space key handling for menu items - Focus restored to trigger element on close ### Editor Context Menus - Added keyboard shortcut (Shift+F10) to open context menus - Full arrow key navigation and Enter/Space activation - Applied to both SQL editor and ES editor ### Aria Labels - Added aria-label to icon-only buttons in 6 dialog files - Added translation keys for accessibility labels ### Export Target - Refactored to single interactive button control - Eliminated nested focus targets ## Files Modified (25) - src/components/ui/combobox/SearchableSelect.vue - src/components/path-breadcrumb.vue - src/layout/components/tool-bar-right.vue - src/views/connect/components/connect-list.vue - src/views/connect/components/dynamodb-connect-dialog.vue - src/views/connect/components/es-connect-dialog.vue - src/views/editor/dynamo-editor/components/delete-confirm-modal.vue - src/views/editor/dynamo-editor/components/sql-editor.vue - src/views/editor/dynamo-editor/components/ui-editor.vue - src/views/editor/es-editor/index.vue - src/views/file/components/context-menu.vue - src/views/file/components/file-list.vue - src/views/file/components/new-file-dialog.vue - src/views/import-export/components/export-target-output.vue - src/views/manage/components/alias-dialog.vue - src/views/manage/components/cluster-state.vue - src/views/manage/components/create-index-modal.vue - src/views/manage/components/delete-index-modal.vue - src/views/manage/components/dynamo-table-manage.vue - src/views/manage/components/index-dialog.vue - src/views/manage/components/modify-index-modal.vue - src/views/manage/components/shard-manage.vue - src/views/manage/components/switch-alias-dialog.vue - src/views/manage/components/table-settings-modal.vue - src/views/manage/components/template-dialog.vue Closes #396
Blankll
force-pushed
the
feat/keyboard-accessibility-improvements
branch
from
e1c8309 to
c4c3d88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements comprehensive keyboard accessibility improvements across the entire application, resolving #396.
Key Changes
SearchableSelect Component - Migrated to Radix Vue Combobox for built-in keyboard support (ArrowUp/Down/Enter/Escape)
Interactive Elements - Added
tabindex,role="button",@keydown.enter,@keydown.spaceto connection cards, file items, navigation icons, toolbar favorites, breadcrumb items, node cards, and table headersForm Submission - Added
@submit.preventto 8 modal dialog forms for proper Enter key submissionConfirmation Dialogs - Scoped Enter key to confirm buttons only, preventing accidental destructive actions
Context Menus - Full keyboard support with ARIA roles, focus management, and Shift+F10 opener for editor context menus
Aria Labels - Added to icon-only buttons in 6 dialog files
Test Plan
Related Issues
Refer #396
Screenshots
N/A - Accessibility improvements are non-visual