Skip to content

Commit 3446963

Browse files
committed
Regression test for UnicodeError in make_request.
1 parent c253ddb commit 3446963

1 file changed

Lines changed: 16 additions & 0 deletions

File tree

gcm/test.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,22 @@ def test_handle_plaintext_response(self):
184184
res = self.gcm.handle_plaintext_response(response)
185185
self.assertEqual(res, '3456')
186186

187+
@patch('urllib2.urlopen')
188+
def test_make_request_unicode(self, urlopen_mock):
189+
""" Regression: Test make_request with unicode payload. """
190+
191+
# Set mock value for urlopen return value
192+
urlopen_mock.return_value = MockResponse('blah')
193+
194+
data = {
195+
'message': u'\x80abc'
196+
}
197+
198+
self.assertEquals(
199+
self.gcm.make_request(data, is_json=False),
200+
'blah'
201+
)
202+
187203
def test_retry_plaintext_request_ok(self):
188204
returns = [GCMUnavailableException(), GCMUnavailableException(), 'id=123456789']
189205

0 commit comments

Comments
 (0)