Skip to content

Commit 2452670

Browse files
committed
Clean up CI labels and Node 24 workflow settings
1 parent ab33920 commit 2452670

6 files changed

Lines changed: 25 additions & 32 deletions

File tree

.github/workflows/binary_tarballs.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ permissions:
55
actions: read
66
contents: write
77

8+
env:
9+
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
10+
811
concurrency:
912
group: gemc-binary-tarballs-${{ github.event.workflow_run.id || github.ref }}
1013
cancel-in-progress: true

.github/workflows/codeql.yml

Lines changed: 4 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
name: "CodeQL Advanced"
22

3+
env:
4+
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
5+
36
on:
47
push:
58
branches: [ "main" ]
@@ -29,9 +32,6 @@ jobs:
2932
# - https://gh.io/using-larger-runners (GitHub.com only)
3033
# Consider using larger runners or machines with greater resources for possible analysis time improvements.
3134
runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }}
32-
# Use a container with G4 installed
33-
container: ghcr.io/gemc/g4install:11.4.0-ubuntu-24.04
34-
3535
permissions:
3636
# required for all workflows
3737
security-events: write
@@ -50,7 +50,7 @@ jobs:
5050
- language: actions
5151
build-mode: none
5252
- language: c-cpp
53-
build-mode: manual
53+
build-mode: none
5454
- language: python
5555
build-mode: none
5656
# CodeQL supports the following values keywords for 'language': 'actions', 'c-cpp', 'csharp', 'go', 'java-kotlin', 'javascript-typescript', 'python', 'ruby', 'swift'
@@ -99,30 +99,6 @@ jobs:
9999
# For more details on CodeQL's query packs, refer to: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
100100
# queries: security-extended,security-and-quality
101101

102-
# If the analyze step fails for one of the languages you are analyzing with
103-
# "We were unable to automatically build your code", modify the matrix above
104-
# to set the build mode to "manual" for that language. Then modify this step
105-
# to build your code.
106-
# ℹ️ Command-line programs to run using the OS shell.
107-
# 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
108-
- if: matrix.build-mode == 'manual'
109-
shell: bash
110-
env:
111-
GEMC_SKIP_PYTHON_ENV_INSTALL: "1"
112-
run: |
113-
echo "Starting manual build for CodeQL..."
114-
115-
apt-get update
116-
apt-get install -y python3-venv
117-
118-
export DOCKER_ENTRYPOINT_SOURCE_ONLY=1
119-
. /usr/local/bin/docker-entrypoint.sh
120-
module load geant4
121-
122-
./ci/build.sh
123-
124-
echo "Manual build finished."
125-
126102
- name: Perform CodeQL Analysis
127103
uses: github/codeql-action/analyze@v4
128104
env:

.github/workflows/dockers_deploy_and_test.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ permissions:
88
env:
99
GEMC_TAG: dev # default gemc tag
1010
GEANT4_TAG: 11.4.1 # default geant4 tag
11+
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
1112

1213
concurrency:
1314
group: gemc-images-${{ github.ref }}
@@ -71,7 +72,7 @@ jobs:
7172
# uses matrix_build
7273
build_arch:
7374
if: ${{ github.event_name != 'pull_request' }}
74-
name: ${{ matrix.gemc_tag }} [${{ matrix.image }}/${{ matrix.image_tag }} ${{ matrix.arch }}]
75+
name: ${{ matrix.image }}/${{ matrix.image_tag }} ${{ matrix.arch }}
7576
needs: [ overview, discover ]
7677
runs-on: ${{ matrix.runner }}
7778
strategy:
@@ -205,7 +206,7 @@ jobs:
205206
# from already-pushed per-arch image tags.
206207
manifest:
207208
if: ${{ github.event_name != 'pull_request' }}
208-
name: ${{ matrix.gemc_tag }} [${{ matrix.image }}/${{ matrix.image_tag }}]
209+
name: ${{ matrix.image }}/${{ matrix.image_tag }}
209210
needs: [ build_arch, discover ]
210211
runs-on: ubuntu-latest
211212
# If arm64 was skipped (e.g., archlinux), still publish amd64-only manifest.

.github/workflows/doxygen.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ permissions:
33
contents: read
44
pull-requests: write
55

6+
env:
7+
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
8+
69
on:
710
push:
811
branches:
@@ -34,6 +37,7 @@ jobs:
3437
deploy-doxygen:
3538
needs: build-doxygen
3639
permissions:
40+
actions: read
3741
pages: write
3842
id-token: write
3943
environment:

.github/workflows/sanitize.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ name: Sanitize
22
permissions:
33
contents: read
44

5+
env:
6+
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
7+
58
concurrency:
69
group: sanitize-${{ github.workflow }}-${{ github.ref }}
710
cancel-in-progress: true
@@ -56,7 +59,7 @@ jobs:
5659
echo '${{ steps.scan.outputs.matrix_sanitize }}'
5760
5861
build-with-sanitizer:
59-
name: ${{ matrix.gemc_tag }} [${{ matrix.baseos }}/${{ matrix.baseos_tag }} ${{ matrix.arch }}] ${{ matrix.sanitizer }}
62+
name: ${{ matrix.baseos }}/${{ matrix.baseos_tag }} ${{ matrix.arch }} ${{ matrix.sanitizer }}
6063
needs: [ discover ]
6164
strategy:
6265
fail-fast: false

releases/0.3.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ This version includes:
1616
images using runtime packages only. These tests install Geant4 datasets into
1717
the unpacked tarball and run `gemc -v` plus smoke tests after the tarballs are
1818
attached to the `dev` release.
19+
- Cleaned up CI job labels, opted JavaScript-based workflow actions into
20+
Node.js 24, and adjusted CodeQL to avoid the Actions overlay-base fallback
21+
warning.
1922
- Isolated ROOT linkage to the ROOT gstreamer plugin so the main `gemc`
2023
executable can run without ROOT shared libraries.
2124
- Removed the need for GEMC-specific environment variables in Python example
@@ -44,7 +47,7 @@ This version includes:
4447
- Updated the Cherenkov homepage documentation for the neutral radiator
4548
variations and one-electron quick workflow.
4649
- Updated the Cherenkov example documentation to use a one-electron quick
47-
workflow and to note that demonstration optical constants may be unphysical.
50+
workflow and to note that optical constants may be unphysical in the demo.
4851

4952
<br/>
5053

@@ -53,6 +56,9 @@ This version includes:
5356
- Added a `Binary Tarballs` workflow that uploads deploy-produced tarballs to
5457
the `dev` release and then tests those release assets. It can also run the
5558
same install checks on a nightly schedule or by manual dispatch.
59+
- Removed redundant `dev` prefixes from deploy and sanitizer matrix job names.
60+
- Updated CodeQL to use `build-mode: none` for all analyzed languages and
61+
removed the manual Geant4 container build from the analysis workflow.
5662
- Added analyzer coverage in `pygemc` for y-vs-x plotting and CLI image output.
5763

5864
<br/>

0 commit comments

Comments
 (0)