fix: remove dead birkConstant branch in getMaterialPropertyFromString

Jah-yee · Jah-yee · commit 32a25c2bcbfb · 2026-06-06T21:21:41.000+08:00
Remove unreachable branch that tested for "birkConstant" (typo, missing 's'). The canonical key is "birksConstant" but Birks constant is loaded via assign_if_set, not name-dispatch — so this branch was dead code. Fixes #138
diff --git a/gemc/gsystem/gmaterial.cc b/gemc/gsystem/gmaterial.cc
@@ -136,8 +136,6 @@ void GMaterial::getMaterialPropertyFromString(const std::string &parameter, cons
 			slowtimeconstant = gutilities::getG4Number(trimmedComponent);
 		} else if (propertyName == "yieldratio") {
 			yieldratio = gutilities::getG4Number(trimmedComponent);
-		} else if (propertyName == "birkConstant") {
-			birksConstant = gutilities::getG4Number(trimmedComponent);
 		} else if (propertyName == "rayleigh") {
 			rayleigh.push_back(gutilities::getG4Number(trimmedComponent));
 		}

Original file line number	Diff line number	Diff line change
`@@ -136,8 +136,6 @@ void GMaterial::getMaterialPropertyFromString(const std::string &parameter, cons`
`136`	`136`	`slowtimeconstant = gutilities::getG4Number(trimmedComponent);`
`137`	`137`	`} else if (propertyName == "yieldratio") {`
`138`	`138`	`yieldratio = gutilities::getG4Number(trimmedComponent);`
`139`		`- } else if (propertyName == "birkConstant") {`
`140`		`- birksConstant = gutilities::getG4Number(trimmedComponent);`
`141`	`139`	`} else if (propertyName == "rayleigh") {`
`142`	`140`	`rayleigh.push_back(gutilities::getG4Number(trimmedComponent));`
`143`	`141`	`}`