Merge pull request #157 from zhaozhiwen/fix/110-cad-dirlocation-mutation

maureeungaro · web-flow · commit 410a6be00805 · 2026-06-13T09:39:21.000-04:00
Stop mutating dirLocation while importing CAD files
diff --git a/gemc/gsystem/gsystemFactories/cad/loadGeometry.cc b/gemc/gsystem/gsystemFactories/cad/loadGeometry.cc
@@ -26,7 +26,7 @@ void GSystemCADFactory::loadGeometry(GSystem* s) {
 
 		// Import each STL as a volume. Each volume name is derived from the filename.
 		for (const auto& cf : cadFiles) {
-			s->addVolumeFromFile(GSYSTEMCADTFACTORYLABEL, dirLocation.append("/").append(cf));
+			s->addVolumeFromFile(GSYSTEMCADTFACTORYLABEL, dirLocation + "/" + cf);
 		}
 
 		// If the file cad__<variation>.yaml is found in dirLocation, modify the gvolumes accordingly.

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ void GSystemCADFactory::loadGeometry(GSystem* s) {`
`26`	`26`
`27`	`27`	`// Import each STL as a volume. Each volume name is derived from the filename.`
`28`	`28`	`for (const auto& cf : cadFiles) {`
`29`		`- s->addVolumeFromFile(GSYSTEMCADTFACTORYLABEL, dirLocation.append("/").append(cf));`
	`29`	`+ s->addVolumeFromFile(GSYSTEMCADTFACTORYLABEL, dirLocation + "/" + cf);`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`// If the file cad__<variation>.yaml is found in dirLocation, modify the gvolumes accordingly.`