Merge pull request #160 from zhaozhiwen/fix/121-help-no-topic

maureeungaro · web-flow · commit 7dbd173c5c44 · 2026-06-13T09:40:31.000-04:00
Do not crash on "gemc help" with no topic
diff --git a/gemc/goptions/goptions.cc b/gemc/goptions/goptions.cc
@@ -100,7 +100,9 @@ GOptions::GOptions(int argc, char* argv[], const GOptions& user_defined_options)
 			exit(EXIT_SUCCESS);
 		}
 		else if (strcmp(argv[i], "help") == 0) {
-			printOptionOrSwitchHelp(argv[i + 1]);
+			// "gemc help <topic>" shows topic help; bare "gemc help" shows the general help index.
+			if (i + 1 < argc) { printOptionOrSwitchHelp(argv[i + 1]); }
+			else { printHelp(); }
 			exit(EXIT_SUCCESS);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,9 @@ GOptions::GOptions(int argc, char* argv[], const GOptions& user_defined_options)`
`100`	`100`	`exit(EXIT_SUCCESS);`
`101`	`101`	`}`
`102`	`102`	`else if (strcmp(argv[i], "help") == 0) {`
`103`		`- printOptionOrSwitchHelp(argv[i + 1]);`
	`103`	`+ // "gemc help <topic>" shows topic help; bare "gemc help" shows the general help index.`
	`104`	`+ if (i + 1 < argc) { printOptionOrSwitchHelp(argv[i + 1]); }`
	`105`	`+ else { printHelp(); }`
`104`	`106`	`exit(EXIT_SUCCESS);`
`105`	`107`	`}`
`106`	`108`	`}`