using direct test names so can run specific meson test. gstreamer test with 1 thread per event - no writing output yet

Author: maureeungaro

api/meson.build

@@ -3,12 +3,12 @@ python_exe = import('python').find_installation('python3')
 
 install_subdir(meson.current_source_dir(), install_dir : '.')
 
-test(' ## templates help',
+test('api_template_help',
      python_exe,
      env : {'PYTHONDONTWRITEBYTECODE': '1'},
      args : [api_dir + 'system_template.py', '-h'])
 
-test(' ## templates show solid creators',
+test('api_show_solid _creators',
      python_exe,
      env : {'PYTHONDONTWRITEBYTECODE': '1'},
      args : [api_dir + 'system_template.py', '-sl'])
@@ -26,28 +26,28 @@ g4objects = {
 
 foreach volume: g4objects.keys()
     pars = g4objects[volume]
-    test(' ## template show code for volume ' + volume,
+    test('api_show_template_code_for_' + volume,
          python_exe,
          env : {'PYTHONDONTWRITEBYTECODE': '1'},
          args : [api_dir + 'system_template.py', '-gv', volume])
-    test(' ## template show code for volume ' + volume + ' with parameters ' + pars,
+    test('api_template_show_code_for_volume' + volume + '_with_parameters_' + pars,
          python_exe,
          env : {'PYTHONDONTWRITEBYTECODE': '1'},
          args : [api_dir + 'system_template.py', '-gv', volume, '-gvp', pars])
 endforeach
 
-test(' ## template show code for solid G4Cons in silent mode',
+test('api_show_template_code_for_G4Cons',
      python_exe,
      env : {'PYTHONDONTWRITEBYTECODE': '1'},
      args : [api_dir + 'system_template.py', '-gv', 'G4Cons', '-silent'])
 
 test_dir = meson.current_build_dir() + '/../test'
-test(' ## template create system test',
+test('api_create_system',
      python_exe,
      env : {'PYTHONDONTWRITEBYTECODE': '1'},
      args : [api_dir + 'system_template.py', '-s', 'test'], priority : 10)
 foreach format : ['ascii', 'sqlite']
-    test(' ## template build geometry in test for format ' + format,
+    test('api_template_build_geometry_in_test_for_format_' + format,
          python_exe,
          env : {'PYTHONDONTWRITEBYTECODE': '1'},
          args : ['test.py', '-f', format], workdir : test_dir, priority : -10)
@@ -67,16 +67,16 @@ foreach volume: g4objects.keys()
     geo_py = '-write_to=geometry_test_' + volume + '.py'
     test_dir = meson.current_build_dir() + '/../' + test_name
     pars = g4objects[volume]
-    test(' ## template create system test for volume' + volume,
+    test('api_create_template_system_with' + volume,
          python_exe,
          env : {'PYTHONDONTWRITEBYTECODE': '1'},
          args : [api_dir + 'system_template.py', '-s', test_name], priority : 10)
-    test(' ## template replace geometry in test with ' + volume,
+    test('api_template_replace_geometry_with' + volume,
          python_exe,
          env : {'PYTHONDONTWRITEBYTECODE': '1'},
          args: [api_dir + 'system_template.py', '-gv', volume, '-gvp', pars, geo_py, sub_name], workdir : test_dir, priority : -10)
     foreach format : ['ascii', 'sqlite']
-        test(' ## template build geometry in test of replacing geometry with ' + volume + ' with format ' + format,
+        test('api_template_build_geometry_in_test_of_replacing_geometry_with' + volume + '_with_format' + format,
              python_exe,
              env : {'PYTHONDONTWRITEBYTECODE': '1'},
              args : [python_main, '-f', format], workdir : test_dir, priority : -20)

gdata/event/gEventDataCollectionHeader.h

@@ -23,12 +23,13 @@ class GEventDataCollectionHeader {
 	 * \param logger Pointer to a GLogger instance.
 	 */
 	GEventDataCollectionHeader(int n, int tid, std::shared_ptr<GLogger> logger) : g4localEventNumber(n), threadID(tid),
-		log(logger) {
+	                                                                              log(logger) {
 		timeStamp = assignTimeStamp();
 		log->debug(CONSTRUCTOR, "GEventDataCollectionHeader");
-		log->info(1, TPOINTITEM, " Event Number:  ", g4localEventNumber);
-		log->info(1, TPOINTITEM, " Thread ID:  ", threadID);
-		log->info(1, TPOINTITEM, " Time Stamp:  ", timeStamp);
+		log->info(1, "\n",
+		          TPOINTITEM, " Event Number:  ", g4localEventNumber, "\n",
+		          TPOINTITEM, " Thread ID:  ", threadID, "\n",
+		          TPOINTITEM, " Time Stamp:  ", timeStamp);
 	}
 
 	/**
@@ -77,4 +78,3 @@ class GEventDataCollectionHeader {
 
 	std::string timeStamp; ///< The timestamp.
 };
-

gdynamicDigitization/examples/gplugin_test_example.cc

@@ -8,7 +8,7 @@ bool GPlugin_test_example::defineReadoutSpecsImpl() {
 	double gridStartTime = 0;                   // defines the windows grid
 	auto   hitBitSet     = HitBitSet("100000"); // defines what information to be stored in the hit
 
-	readoutSpecs = new GReadoutSpecs(timeWindow, gridStartTime, hitBitSet, digi_logger);
+	readoutSpecs = std::make_shared<GReadoutSpecs>(timeWindow, gridStartTime, hitBitSet, digi_logger);
 
 	return true;
 }
@@ -27,7 +27,8 @@ bool GPlugin_test_example::loadConstantsImpl(int runno, [[maybe_unused]] std::st
 
 	var4 = "hello";
 
-	digi_logger->info(0, " Constants loaded for run number ", runno, " for ctof. var1  is ", var1, " var2 pointer is ", var2, "variation is", variation);
+	digi_logger->info(0, " Constants loaded for run number ", runno, " for ctof. var1  is ", var1,
+		", var2 pointer is ", var2, ", variation is ", variation);
 
 	return true;
 }

gdynamicDigitization/gDosimeterDigitization.cc

@@ -42,7 +42,7 @@ bool GDosimeterDigitization::defineReadoutSpecsImpl() {
 	auto   hitBitSet     = HitBitSet("000001"); // defines what information to be stored in the hit
 
 	// Create a new GReadoutSpecs object with the specified parameters.
-	readoutSpecs = new GReadoutSpecs(timeWindow, gridStartTime, hitBitSet, digi_logger);
+	readoutSpecs = std::make_shared<GReadoutSpecs>(timeWindow, gridStartTime, hitBitSet, digi_logger);
 
 	return true;
 }

gdynamicDigitization/gFluxDigitization.cc

@@ -22,7 +22,7 @@ bool GFluxDigitization::defineReadoutSpecsImpl() {
 
 	// Create a new GReadoutSpecs object using the provided parameters.
 	// The digi_logger (obtained via set_loggers()) is used for logging.
-	readoutSpecs = new GReadoutSpecs(timeWindow, gridStartTime, hitBitSet, digi_logger);
+	readoutSpecs = std::make_shared<GReadoutSpecs>(timeWindow, gridStartTime, hitBitSet, digi_logger);
 
 	return true;
 }

gdynamicDigitization/gParticleCounterDigitization.cc

@@ -6,7 +6,7 @@ bool GParticleCounterDigitization::defineReadoutSpecsImpl() {
 	double gridStartTime = 0;                   // defines the window grid
 	auto  hitBitSet     = HitBitSet("000000"); // defines what information to be stored in the hit
 
-	readoutSpecs = new GReadoutSpecs(timeWindow, gridStartTime, hitBitSet, digi_logger);
+	readoutSpecs = std::make_shared<GReadoutSpecs>(timeWindow, gridStartTime, hitBitSet, digi_logger);
 
 	return true;
 }

gdynamicDigitization/gdynamicdigitization.h

@@ -253,10 +253,9 @@ class GDynamicDigitization {
 	};
 	[[nodiscard]] virtual bool defineReadoutSpecsImpl() = 0;
 
-	/// Pointer to the readout specifications.
-	GReadoutSpecs* readoutSpecs = nullptr;
-	/// Pointer to the translation table.
-	GTranslationTable* translationTable = nullptr;
+	/// After init, we never mutate these:
+	std::shared_ptr<const GReadoutSpecs>  readoutSpecs;
+	std::shared_ptr<const GTranslationTable> translationTable;
 
 	/**
 	 * \brief Dynamically instantiates a GDynamicDigitization object from a dynamic library.
@@ -292,7 +291,7 @@ class GDynamicDigitization {
 protected:
 	/// Optional pointer to GOptions.
 	std::optional<GOptions*> gopts;
-	/// Data, Translation Tables and digitization loggers.
+	/// Data, Translation Tables, and digitization loggers.
 	std::shared_ptr<GLogger> data_logger, tt_logger, digi_logger;
 
 	/**