Merge pull request #144 from zhaozhiwen/fix/109-sphere-vertex-radius

maureeungaro · web-flow · commit eaccfc0d401f · 2026-06-13T09:18:17.000-04:00
Fix sphere vertex sampling: compare squared radius to squared bound
diff --git a/gemc/gparticle/gparticle.cc b/gemc/gparticle/gparticle.cc
@@ -166,7 +166,7 @@ G4ThreeVector Gparticle::calculateVertex() {
 				z      = randomizeNumberFromSigmaWithModel(0, max_radius, gutilities::uniform);
 				radius = x * x + y * y + z * z;
 			}
-			while (radius > max_radius);
+			while (radius > max_radius * max_radius);
 
 			// Offset the sampled point by the nominal vertex.
 			x = x + v.x();

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ G4ThreeVector Gparticle::calculateVertex() {`
`166`	`166`	`z = randomizeNumberFromSigmaWithModel(0, max_radius, gutilities::uniform);`
`167`	`167`	`radius = x * x + y * y + z * z;`
`168`	`168`	`}`
`169`		`- while (radius > max_radius);`
	`169`	`+ while (radius > max_radius * max_radius);`
`170`	`170`
`171`	`171`	`// Offset the sampled point by the nominal vertex.`
`172`	`172`	`x = x + v.x();`